[clang-tidy] rename_check.py misc-string-constructor bugprone-string-constructor
Summary: Rename misc-string-constructor to bugprone-string-constructor + manually update the lenght of '==='s in the doc file. Reviewers: hokein, xazax.hun Reviewed By: hokein, xazax.hun Subscribers: mgorny, xazax.hun, cfe-commits Differential Revision: https://reviews.llvm.org/D40388 llvm-svn: 318916
This commit is contained in:
parent
c01f7f131b
commit
a3251bf24c
|
@ -13,6 +13,7 @@
|
||||||
#include "CopyConstructorInitCheck.h"
|
#include "CopyConstructorInitCheck.h"
|
||||||
#include "IntegerDivisionCheck.h"
|
#include "IntegerDivisionCheck.h"
|
||||||
#include "MisplacedOperatorInStrlenInAllocCheck.h"
|
#include "MisplacedOperatorInStrlenInAllocCheck.h"
|
||||||
|
#include "StringConstructorCheck.h"
|
||||||
#include "SuspiciousMemsetUsageCheck.h"
|
#include "SuspiciousMemsetUsageCheck.h"
|
||||||
#include "UndefinedMemoryManipulationCheck.h"
|
#include "UndefinedMemoryManipulationCheck.h"
|
||||||
|
|
||||||
|
@ -29,6 +30,8 @@ public:
|
||||||
"bugprone-integer-division");
|
"bugprone-integer-division");
|
||||||
CheckFactories.registerCheck<MisplacedOperatorInStrlenInAllocCheck>(
|
CheckFactories.registerCheck<MisplacedOperatorInStrlenInAllocCheck>(
|
||||||
"bugprone-misplaced-operator-in-strlen-in-alloc");
|
"bugprone-misplaced-operator-in-strlen-in-alloc");
|
||||||
|
CheckFactories.registerCheck<StringConstructorCheck>(
|
||||||
|
"bugprone-string-constructor");
|
||||||
CheckFactories.registerCheck<SuspiciousMemsetUsageCheck>(
|
CheckFactories.registerCheck<SuspiciousMemsetUsageCheck>(
|
||||||
"bugprone-suspicious-memset-usage");
|
"bugprone-suspicious-memset-usage");
|
||||||
CheckFactories.registerCheck<UndefinedMemoryManipulationCheck>(
|
CheckFactories.registerCheck<UndefinedMemoryManipulationCheck>(
|
||||||
|
|
|
@ -5,6 +5,7 @@ add_clang_library(clangTidyBugproneModule
|
||||||
CopyConstructorInitCheck.cpp
|
CopyConstructorInitCheck.cpp
|
||||||
IntegerDivisionCheck.cpp
|
IntegerDivisionCheck.cpp
|
||||||
MisplacedOperatorInStrlenInAllocCheck.cpp
|
MisplacedOperatorInStrlenInAllocCheck.cpp
|
||||||
|
StringConstructorCheck.cpp
|
||||||
SuspiciousMemsetUsageCheck.cpp
|
SuspiciousMemsetUsageCheck.cpp
|
||||||
UndefinedMemoryManipulationCheck.cpp
|
UndefinedMemoryManipulationCheck.cpp
|
||||||
|
|
||||||
|
|
|
@ -16,7 +16,7 @@ using namespace clang::ast_matchers;
|
||||||
|
|
||||||
namespace clang {
|
namespace clang {
|
||||||
namespace tidy {
|
namespace tidy {
|
||||||
namespace misc {
|
namespace bugprone {
|
||||||
|
|
||||||
AST_MATCHER_P(IntegerLiteral, isBiggerThan, unsigned, N) {
|
AST_MATCHER_P(IntegerLiteral, isBiggerThan, unsigned, N) {
|
||||||
return Node.getValue().getZExtValue() > N;
|
return Node.getValue().getZExtValue() > N;
|
||||||
|
@ -129,6 +129,6 @@ void StringConstructorCheck::check(const MatchFinder::MatchResult &Result) {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
} // namespace misc
|
} // namespace bugprone
|
||||||
} // namespace tidy
|
} // namespace tidy
|
||||||
} // namespace clang
|
} // namespace clang
|
|
@ -7,19 +7,19 @@
|
||||||
//
|
//
|
||||||
//===----------------------------------------------------------------------===//
|
//===----------------------------------------------------------------------===//
|
||||||
|
|
||||||
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_STRING_CONSTRUCTOR_H
|
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_STRING_CONSTRUCTOR_H
|
||||||
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_STRING_CONSTRUCTOR_H
|
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_STRING_CONSTRUCTOR_H
|
||||||
|
|
||||||
#include "../ClangTidy.h"
|
#include "../ClangTidy.h"
|
||||||
|
|
||||||
namespace clang {
|
namespace clang {
|
||||||
namespace tidy {
|
namespace tidy {
|
||||||
namespace misc {
|
namespace bugprone {
|
||||||
|
|
||||||
/// Finds suspicious string constructor and check their parameters.
|
/// Finds suspicious string constructor and check their parameters.
|
||||||
///
|
///
|
||||||
/// For the user-facing documentation see:
|
/// For the user-facing documentation see:
|
||||||
/// http://clang.llvm.org/extra/clang-tidy/checks/misc-string-constructor.html
|
/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-string-constructor.html
|
||||||
class StringConstructorCheck : public ClangTidyCheck {
|
class StringConstructorCheck : public ClangTidyCheck {
|
||||||
public:
|
public:
|
||||||
StringConstructorCheck(StringRef Name, ClangTidyContext *Context);
|
StringConstructorCheck(StringRef Name, ClangTidyContext *Context);
|
||||||
|
@ -32,8 +32,8 @@ private:
|
||||||
const unsigned int LargeLengthThreshold;
|
const unsigned int LargeLengthThreshold;
|
||||||
};
|
};
|
||||||
|
|
||||||
} // namespace misc
|
} // namespace bugprone
|
||||||
} // namespace tidy
|
} // namespace tidy
|
||||||
} // namespace clang
|
} // namespace clang
|
||||||
|
|
||||||
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MISC_STRING_CONSTRUCTOR_H
|
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_BUGPRONE_STRING_CONSTRUCTOR_H
|
|
@ -31,7 +31,6 @@ add_clang_library(clangTidyMiscModule
|
||||||
SizeofExpressionCheck.cpp
|
SizeofExpressionCheck.cpp
|
||||||
StaticAssertCheck.cpp
|
StaticAssertCheck.cpp
|
||||||
StringCompareCheck.cpp
|
StringCompareCheck.cpp
|
||||||
StringConstructorCheck.cpp
|
|
||||||
StringIntegerAssignmentCheck.cpp
|
StringIntegerAssignmentCheck.cpp
|
||||||
StringLiteralWithEmbeddedNulCheck.cpp
|
StringLiteralWithEmbeddedNulCheck.cpp
|
||||||
SuspiciousEnumUsageCheck.cpp
|
SuspiciousEnumUsageCheck.cpp
|
||||||
|
|
|
@ -38,7 +38,6 @@
|
||||||
#include "SizeofExpressionCheck.h"
|
#include "SizeofExpressionCheck.h"
|
||||||
#include "StaticAssertCheck.h"
|
#include "StaticAssertCheck.h"
|
||||||
#include "StringCompareCheck.h"
|
#include "StringCompareCheck.h"
|
||||||
#include "StringConstructorCheck.h"
|
|
||||||
#include "StringIntegerAssignmentCheck.h"
|
#include "StringIntegerAssignmentCheck.h"
|
||||||
#include "StringLiteralWithEmbeddedNulCheck.h"
|
#include "StringLiteralWithEmbeddedNulCheck.h"
|
||||||
#include "SuspiciousEnumUsageCheck.h"
|
#include "SuspiciousEnumUsageCheck.h"
|
||||||
|
@ -114,8 +113,6 @@ public:
|
||||||
"misc-sizeof-expression");
|
"misc-sizeof-expression");
|
||||||
CheckFactories.registerCheck<StaticAssertCheck>("misc-static-assert");
|
CheckFactories.registerCheck<StaticAssertCheck>("misc-static-assert");
|
||||||
CheckFactories.registerCheck<StringCompareCheck>("misc-string-compare");
|
CheckFactories.registerCheck<StringCompareCheck>("misc-string-compare");
|
||||||
CheckFactories.registerCheck<StringConstructorCheck>(
|
|
||||||
"misc-string-constructor");
|
|
||||||
CheckFactories.registerCheck<StringIntegerAssignmentCheck>(
|
CheckFactories.registerCheck<StringIntegerAssignmentCheck>(
|
||||||
"misc-string-integer-assignment");
|
"misc-string-integer-assignment");
|
||||||
CheckFactories.registerCheck<StringLiteralWithEmbeddedNulCheck>(
|
CheckFactories.registerCheck<StringLiteralWithEmbeddedNulCheck>(
|
||||||
|
|
|
@ -57,6 +57,9 @@ The improvements are...
|
||||||
Improvements to clang-tidy
|
Improvements to clang-tidy
|
||||||
--------------------------
|
--------------------------
|
||||||
|
|
||||||
|
- The 'misc-string-constructor' check was renamed to `bugprone-string-constructor
|
||||||
|
<http://clang.llvm.org/extra/clang-tidy/checks/bugprone-string-constructor.html>`_
|
||||||
|
|
||||||
- New `google-avoid-throwing-objc-exception
|
- New `google-avoid-throwing-objc-exception
|
||||||
<http://clang.llvm.org/extra/clang-tidy/checks/google-objc-avoid-throwing-exception.html>`_ check
|
<http://clang.llvm.org/extra/clang-tidy/checks/google-objc-avoid-throwing-exception.html>`_ check
|
||||||
|
|
||||||
|
|
|
@ -1,7 +1,7 @@
|
||||||
.. title:: clang-tidy - misc-string-constructor
|
.. title:: clang-tidy - bugprone-string-constructor
|
||||||
|
|
||||||
misc-string-constructor
|
bugprone-string-constructor
|
||||||
=======================
|
===========================
|
||||||
|
|
||||||
Finds string constructors that are suspicious and probably errors.
|
Finds string constructors that are suspicious and probably errors.
|
||||||
|
|
|
@ -20,6 +20,7 @@ Clang-Tidy Checks
|
||||||
bugprone-copy-constructor-init
|
bugprone-copy-constructor-init
|
||||||
bugprone-integer-division
|
bugprone-integer-division
|
||||||
bugprone-misplaced-operator-in-strlen-in-alloc
|
bugprone-misplaced-operator-in-strlen-in-alloc
|
||||||
|
bugprone-string-constructor
|
||||||
bugprone-suspicious-memset-usage
|
bugprone-suspicious-memset-usage
|
||||||
bugprone-undefined-memory-manipulation
|
bugprone-undefined-memory-manipulation
|
||||||
cert-dcl03-c (redirects to misc-static-assert) <cert-dcl03-c>
|
cert-dcl03-c (redirects to misc-static-assert) <cert-dcl03-c>
|
||||||
|
@ -132,7 +133,6 @@ Clang-Tidy Checks
|
||||||
misc-sizeof-expression
|
misc-sizeof-expression
|
||||||
misc-static-assert
|
misc-static-assert
|
||||||
misc-string-compare
|
misc-string-compare
|
||||||
misc-string-constructor
|
|
||||||
misc-string-integer-assignment
|
misc-string-integer-assignment
|
||||||
misc-string-literal-with-embedded-nul
|
misc-string-literal-with-embedded-nul
|
||||||
misc-suspicious-enum-usage
|
misc-suspicious-enum-usage
|
||||||
|
|
|
@ -1,4 +1,4 @@
|
||||||
// RUN: %check_clang_tidy %s misc-string-constructor %t
|
// RUN: %check_clang_tidy %s bugprone-string-constructor %t
|
||||||
|
|
||||||
namespace std {
|
namespace std {
|
||||||
template <typename T>
|
template <typename T>
|
||||||
|
@ -21,7 +21,7 @@ extern const char kText3[];
|
||||||
|
|
||||||
void Test() {
|
void Test() {
|
||||||
std::string str('x', 4);
|
std::string str('x', 4);
|
||||||
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: string constructor parameters are probably swapped; expecting string(count, character) [misc-string-constructor]
|
// CHECK-MESSAGES: [[@LINE-1]]:15: warning: string constructor parameters are probably swapped; expecting string(count, character) [bugprone-string-constructor]
|
||||||
// CHECK-FIXES: std::string str(4, 'x');
|
// CHECK-FIXES: std::string str(4, 'x');
|
||||||
std::wstring wstr(L'x', 4);
|
std::wstring wstr(L'x', 4);
|
||||||
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: string constructor parameters are probably swapped
|
// CHECK-MESSAGES: [[@LINE-1]]:16: warning: string constructor parameters are probably swapped
|
Loading…
Reference in New Issue