From a259116513453e890af0121e7e347b4631969d6f Mon Sep 17 00:00:00 2001 From: Zachary Turner Date: Fri, 2 Oct 2015 22:47:28 +0000 Subject: [PATCH] Updated xfail / skip status on a few tests. TestDiamond and TestSBValueCast were due to a bug in clang. That bug has been fixed, so xfail is removed. However fixing that bug exposed another bug in clang, which is not yet fixed. That bug causes one test to start crashing, and another to fail unexpectedly so the status of those tests is updated as well. llvm-svn: 249208 --- .../lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py | 1 + lldb/test/lang/cpp/diamond/TestDiamond.py | 1 - lldb/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py | 1 + lldb/test/lang/cpp/wchar_t/TestCxxWCharT.py | 1 - 4 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lldb/test/lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py b/lldb/test/lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py index 851b3430e482..a8b69ded6d40 100644 --- a/lldb/test/lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py +++ b/lldb/test/lang/cpp/breakpoint-commands/TestCPPBreakpointCommands.py @@ -11,6 +11,7 @@ class CPPBreakpointCommandsTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) + @expectedFailureWindows def test(self): """Test a sequence of breakpoint command add, list, and delete.""" self.build() diff --git a/lldb/test/lang/cpp/diamond/TestDiamond.py b/lldb/test/lang/cpp/diamond/TestDiamond.py index 308fb13accf9..6c9f6e4a32ae 100644 --- a/lldb/test/lang/cpp/diamond/TestDiamond.py +++ b/lldb/test/lang/cpp/diamond/TestDiamond.py @@ -9,7 +9,6 @@ class CPPTestDiamondInheritance(TestBase): mydir = TestBase.compute_mydir(__file__) - @expectedFailureWindows("llvm.org/pr24764") def test_with_run_command(self): """Test that virtual base classes work in when SBValue objects are used to explore the variable value""" self.build() diff --git a/lldb/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py b/lldb/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py index 3ea22f0b2798..931f546c7779 100644 --- a/lldb/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py +++ b/lldb/test/lang/cpp/incomplete-types/TestCppIncompleteTypes.py @@ -20,6 +20,7 @@ class TestCppIncompleteTypes(TestBase): self.assertFalse(value_a.GetError().Success(), "'expr a' results in an error, but LLDB does not crash") @skipIfGcc + @skipIfWindows # Clang on Windows asserts in external record layout in this case. def test_partial_limit_debug_info(self): self.build() frame = self.get_test_frame('nolimit') diff --git a/lldb/test/lang/cpp/wchar_t/TestCxxWCharT.py b/lldb/test/lang/cpp/wchar_t/TestCxxWCharT.py index 232cda7a5a18..2438873b5154 100644 --- a/lldb/test/lang/cpp/wchar_t/TestCxxWCharT.py +++ b/lldb/test/lang/cpp/wchar_t/TestCxxWCharT.py @@ -20,7 +20,6 @@ class CxxWCharTTestCase(TestBase): self.source = 'main.cpp' self.line = line_number(self.source, '// Set break point at this line.') - @expectedFailureWindows("llvm.org/pr24764") def test(self): """Test that C++ supports wchar_t correctly.""" self.build()