replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Set visibility for available_externally globals. This is important for two reasons: 

* llvm-link would complains about mismatched visibility
* If we produce a relocation with an available_externally, it is good to know that
it is hidden.

llvm-svn: 124633
This commit is contained in:
Rafael Espindola 2011-02-01 00:37:17 +00:00
parent 4fff8f6cff
commit 9fa5a67d3d
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -174,8 +174,7 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV,
// Set visibility for definitions.
NamedDecl::LinkageInfo LV = D->getLinkageAndVisibility();
if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage())
GV->setVisibility(GetLLVMVisibility(LV.visibility()));
GV->setVisibility(GetLLVMVisibility(LV.visibility()));
}
/// Set the symbol visibility of type information (vtable and RTTI)

2
clang/test/CodeGenCXX/visibility-hidden-extern-templates.cpp
View File

@ -20,7 +20,7 @@ void test_X(X<int> xi, X<char> xc) {
xi.g();
// CHECK: declare void @_ZN1XIcE1fEv
xc.f();
// CHECK: define available_externally void @_ZN1XIcE1gEv
// CHECK: define available_externally hidden void @_ZN1XIcE1gEv
xc.g();
}