diff --git a/llvm/include/llvm/IR/Attributes.td b/llvm/include/llvm/IR/Attributes.td index 1019f867aab0..39978c41ac72 100644 --- a/llvm/include/llvm/IR/Attributes.td +++ b/llvm/include/llvm/IR/Attributes.td @@ -236,3 +236,4 @@ def : MergeRule<"adjustCallerSSPLevel">; def : MergeRule<"adjustCallerStackProbes">; def : MergeRule<"adjustCallerStackProbeSize">; def : MergeRule<"adjustMinLegalVectorWidth">; +def : MergeRule<"adjustNullPointerValidAttr">; diff --git a/llvm/lib/IR/Attributes.cpp b/llvm/lib/IR/Attributes.cpp index 9e5f55d49756..d87187481be0 100644 --- a/llvm/lib/IR/Attributes.cpp +++ b/llvm/lib/IR/Attributes.cpp @@ -1709,6 +1709,15 @@ adjustMinLegalVectorWidth(Function &Caller, const Function &Callee) { } } +/// If the inlined function has "null-pointer-is-valid=true" attribute, +/// set this attribute in the caller post inlining. +static void +adjustNullPointerValidAttr(Function &Caller, const Function &Callee) { + if (Callee.nullPointerIsDefined() && !Caller.nullPointerIsDefined()) { + Caller.addFnAttr(Callee.getFnAttribute("null-pointer-is-valid")); + } +} + #define GET_ATTR_COMPAT_FUNC #include "AttributesCompatFunc.inc" diff --git a/llvm/test/Transforms/Inline/attributes.ll b/llvm/test/Transforms/Inline/attributes.ll index c2808ba8c037..66a831bf8179 100644 --- a/llvm/test/Transforms/Inline/attributes.ll +++ b/llvm/test/Transforms/Inline/attributes.ll @@ -333,9 +333,10 @@ define i32 @test_no-use-jump-tables3(i32 %i) "no-jump-tables"="true" { ; CHECK-NEXT: ret i32 } -; Calle with "null-pointer-is-valid"="true" attribute should not be inlined -; into a caller without this attribute. Exception: alwaysinline callee -; can still be inlined. +; Callee with "null-pointer-is-valid"="true" attribute should not be inlined +; into a caller without this attribute. +; Exception: alwaysinline callee can still be inlined but +; "null-pointer-is-valid"="true" should get copied to caller. define i32 @null-pointer-is-valid_callee0(i32 %i) "null-pointer-is-valid"="true" { ret i32 %i @@ -355,6 +356,7 @@ define i32 @null-pointer-is-valid_callee2(i32 %i) { ; CHECK-NEXT: ret i32 } +; No inlining since caller does not have "null-pointer-is-valid"="true" attribute. define i32 @test_null-pointer-is-valid0(i32 %i) { %1 = call i32 @null-pointer-is-valid_callee0(i32 %i) ret i32 %1 @@ -363,17 +365,22 @@ define i32 @test_null-pointer-is-valid0(i32 %i) { ; CHECK-NEXT: ret i32 } -define i32 @test_null-pointer-is-valid1(i32 %i) { +; alwaysinline should force inlining even when caller does not have +; "null-pointer-is-valid"="true" attribute. However, the attribute should be +; copied to caller. +define i32 @test_null-pointer-is-valid1(i32 %i) "null-pointer-is-valid"="false" { %1 = call i32 @null-pointer-is-valid_callee1(i32 %i) ret i32 %1 -; CHECK: @test_null-pointer-is-valid1( +; CHECK: @test_null-pointer-is-valid1(i32 %i) [[NULLPOINTERISVALID:#[0-9]+]] { ; CHECK-NEXT: ret i32 } +; Can inline since both caller and callee have "null-pointer-is-valid"="true" +; attribute. define i32 @test_null-pointer-is-valid2(i32 %i) "null-pointer-is-valid"="true" { %1 = call i32 @null-pointer-is-valid_callee2(i32 %i) ret i32 %1 -; CHECK: @test_null-pointer-is-valid2( +; CHECK: @test_null-pointer-is-valid2(i32 %i) [[NULLPOINTERISVALID]] { ; CHECK-NEXT: ret i32 } @@ -381,3 +388,4 @@ define i32 @test_null-pointer-is-valid2(i32 %i) "null-pointer-is-valid"="true" { ; CHECK: attributes [[FPMAD_TRUE]] = { "less-precise-fpmad"="true" } ; CHECK: attributes [[NOIMPLICITFLOAT]] = { noimplicitfloat } ; CHECK: attributes [[NOUSEJUMPTABLES]] = { "no-jump-tables"="true" } +; CHECK: attributes [[NULLPOINTERISVALID]] = { "null-pointer-is-valid"="true" }