From 9d6055133b223d465da2555e06b50ee127ef4f4e Mon Sep 17 00:00:00 2001 From: Pete Cooper Date: Thu, 10 Nov 2011 21:45:06 +0000 Subject: [PATCH] Add invariant.load metadata to loads from selector references. Allows these loads to later be moved/combined in the optimizer. Fixes llvm-svn: 144318 --- clang/lib/CodeGen/CGObjCMac.cpp | 7 ++++++- clang/test/CodeGenObjC/selector-ref-invariance.m | 9 +++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 clang/test/CodeGenObjC/selector-ref-invariance.m diff --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp index 84277f6827e8..1cbcc58ae5f3 100644 --- a/clang/lib/CodeGen/CGObjCMac.cpp +++ b/clang/lib/CodeGen/CGObjCMac.cpp @@ -5887,7 +5887,12 @@ llvm::Value *CGObjCNonFragileABIMac::EmitSelector(CGBuilderTy &Builder, if (lval) return Entry; - return Builder.CreateLoad(Entry); + llvm::LoadInst* LI = Builder.CreateLoad(Entry); + + LI->setMetadata(CGM.getModule().getMDKindID("invariant.load"), + llvm::MDNode::get(VMContext, + ArrayRef())); + return LI; } /// EmitObjCIvarAssign - Code gen for assigning to a __strong object. /// objc_assign_ivar (id src, id *dst, ptrdiff_t) diff --git a/clang/test/CodeGenObjC/selector-ref-invariance.m b/clang/test/CodeGenObjC/selector-ref-invariance.m new file mode 100644 index 000000000000..e356419de9e8 --- /dev/null +++ b/clang/test/CodeGenObjC/selector-ref-invariance.m @@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -triple x86_64-apple-darwin11 -emit-llvm -fblocks -o - %s | FileCheck %s + +// rdar://6027699 + +void test(id x) { +// CHECK: load i8** @"\01L_OBJC_SELECTOR_REFERENCES_", !invariant.load +// CHECK: @objc_msgSend + [x foo]; +}