replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[CodeGen] Use llvm::join to simplify string joining. 

While there replace stable_sort of std::string with just sort, stability
is not necessary for "simple" value types. No functional change intended.

llvm-svn: 241299
This commit is contained in:
Benjamin Kramer 2015-07-02 21:02:39 +00:00
parent cd55286893
commit 9c218592c8
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/lib/CodeGen/CGCall.cpp
View File

@ -32,7 +32,6 @@
#include "llvm/IR/Intrinsics.h"
#include "llvm/IR/IntrinsicInst.h"
#include "llvm/Transforms/Utils/Local.h"
#include <sstream>
using namespace clang;
using namespace CodeGen;
@ -1544,14 +1543,9 @@ void CodeGenModule::ConstructAttributeList(const CGFunctionInfo &FI,
if (TargetCPU != "")
FuncAttrs.addAttribute("target-cpu", TargetCPU);
if (!Features.empty()) {
std::stable_sort(Features.begin(), Features.end());
std::stringstream TargetFeatures;
std::copy(Features.begin(), Features.end(),
std::ostream_iterator<std::string>(TargetFeatures, ","));
// The drop_back gets rid of the trailing space.
std::sort(Features.begin(), Features.end());
FuncAttrs.addAttribute("target-features",
StringRef(TargetFeatures.str()).drop_back(1));
llvm::join(Features.begin(), Features.end(), ","));
}
}