replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "Move using directive from Job.h to Job.cpp" (r190902) 

Seems like it was intentional to export ArgStringList as
driver::ArgStringList, and e.g. examples/clang-interpreter/main.cpp
uses it this way.

However, exporting it with a typedef seems like a more common way to do it.

llvm-svn: 190906
This commit is contained in:
Hans Wennborg 2013-09-18 00:17:07 +00:00
parent eacc287b49
commit 9b7c8a378a
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clang/include/clang/Driver/Job.h
View File

@ -24,6 +24,9 @@ class Action;
class Command; class Command;
class Tool; class Tool;
// Users of this class will use clang::driver::ArgStringList.
typedef llvm::opt::ArgStringList ArgStringList;
class Job { class Job {
public: public:
enum JobClass { enum JobClass {
@ -65,11 +68,11 @@ class Command : public Job {
/// The list of program arguments (not including the implicit first /// The list of program arguments (not including the implicit first
/// argument, which will be the executable). /// argument, which will be the executable).
llvm::opt::ArgStringList Arguments; ArgStringList Arguments;
public: public:
Command(const Action &_Source, const Tool &_Creator, const char *_Executable, Command(const Action &_Source, const Tool &_Creator, const char *_Executable,
const llvm::opt::ArgStringList &_Arguments); const ArgStringList &_Arguments);
virtual void Print(llvm::raw_ostream &OS, const char *Terminator, virtual void Print(llvm::raw_ostream &OS, const char *Terminator,
bool Quote, bool CrashReport = false) const; bool Quote, bool CrashReport = false) const;
@ -83,7 +86,7 @@ public:
/// getCreator - Return the Tool which caused the creation of this job. /// getCreator - Return the Tool which caused the creation of this job.
const Tool &getCreator() const { return Creator; } const Tool &getCreator() const { return Creator; }
const llvm::opt::ArgStringList &getArguments() const { return Arguments; } const ArgStringList &getArguments() const { return Arguments; }
static bool classof(const Job *J) { static bool classof(const Job *J) {
return J->getKind() == CommandClass; return J->getKind() == CommandClass;

1
clang/lib/Driver/Job.cpp
View File

@ -15,7 +15,6 @@
#include "llvm/Support/raw_ostream.h" #include "llvm/Support/raw_ostream.h"
#include <cassert> #include <cassert>
using namespace clang::driver; using namespace clang::driver;
using llvm::opt::ArgStringList;
using llvm::raw_ostream; using llvm::raw_ostream;
using llvm::StringRef; using llvm::StringRef;