diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index b1d601551412..7bebce16e1f3 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -1301,8 +1301,14 @@ bool Sema::FindDeallocationFunction(SourceLocation StartLoc, CXXRecordDecl *RD, llvm::SmallVector Matches; for (LookupResult::iterator F = Found.begin(), FEnd = Found.end(); F != FEnd; ++F) { - CXXMethodDecl *Delete = cast((*F)->getUnderlyingDecl()); - if (Delete->isUsualDeallocationFunction()) + NamedDecl *ND = (*F)->getUnderlyingDecl(); + + // Ignore template operator delete members from the check for a usual + // deallocation function. + if (isa(ND)) + continue; + + if (cast(ND)->isUsualDeallocationFunction()) Matches.push_back(F.getPair()); } diff --git a/clang/test/SemaCXX/new-delete.cpp b/clang/test/SemaCXX/new-delete.cpp index 816b808346af..b127e667c531 100644 --- a/clang/test/SemaCXX/new-delete.cpp +++ b/clang/test/SemaCXX/new-delete.cpp @@ -332,3 +332,15 @@ namespace PR7810 { static void operator delete(void *volatile); }; } + +// Don't crash on template delete operators +namespace TemplateDestructors { + struct S { + virtual ~S() {} + + void* operator new(const size_t size); + template void* operator new(const size_t, const int, T*); + void operator delete(void*, const size_t); + template void operator delete(void*, const size_t, const int, T*); + }; +}