Implement rdar://6319320: give a good diagnostic for cases where people
are trying to use the old GCC "casts as lvalue" extension. We don't and will hopefully never support this. llvm-svn: 59460
This commit is contained in:
parent
753567f2c1
commit
9b3bbe9db7
|
@ -99,6 +99,7 @@ public:
|
|||
MLV_IncompleteVoidType,
|
||||
MLV_DuplicateVectorComponents,
|
||||
MLV_InvalidExpression,
|
||||
MLV_LValueCast, // Specialized form of MLV_InvalidExpression.
|
||||
MLV_IncompleteType,
|
||||
MLV_ConstQualified,
|
||||
MLV_ArrayType,
|
||||
|
|
|
@ -1225,6 +1225,8 @@ DIAG(err_typecheck_expression_not_modifiable_lvalue, ERROR,
|
|||
"expression is not assignable")
|
||||
DIAG(err_typecheck_incomplete_type_not_modifiable_lvalue, ERROR,
|
||||
"incomplete type '%0' is not assignable")
|
||||
DIAG(err_typecheck_lvalue_casts_not_supported, ERROR,
|
||||
"assignment to cast is illegal, lvalue casts are not supported")
|
||||
|
||||
DIAG(err_typecheck_duplicate_vector_components_not_mlvalue, ERROR,
|
||||
"vector is not assignable (contains duplicate components)")
|
||||
|
|
|
@ -495,7 +495,15 @@ Expr::isModifiableLvalueResult Expr::isModifiableLvalue(ASTContext &Ctx) const {
|
|||
case LV_NotObjectType: return MLV_NotObjectType;
|
||||
case LV_IncompleteVoidType: return MLV_IncompleteVoidType;
|
||||
case LV_DuplicateVectorComponents: return MLV_DuplicateVectorComponents;
|
||||
case LV_InvalidExpression: return MLV_InvalidExpression;
|
||||
case LV_InvalidExpression:
|
||||
// If the top level is a C-style cast, and the subexpression is a valid
|
||||
// lvalue, then this is probably a use of the old-school "cast as lvalue"
|
||||
// GCC extension. We don't support it, but we want to produce good
|
||||
// diagnostics when it happens so that the user knows why.
|
||||
if (const CStyleCastExpr *CE = dyn_cast<CStyleCastExpr>(this))
|
||||
if (CE->getSubExpr()->isLvalue(Ctx) == LV_Valid)
|
||||
return MLV_LValueCast;
|
||||
return MLV_InvalidExpression;
|
||||
}
|
||||
|
||||
QualType CT = Ctx.getCanonicalType(getType());
|
||||
|
|
|
@ -2345,6 +2345,10 @@ inline QualType Sema::CheckAssignmentOperands( // C99 6.5.16.1
|
|||
Diag(loc, diag::err_typecheck_non_object_not_modifiable_lvalue,
|
||||
lhsType.getAsString(), lex->getSourceRange());
|
||||
return QualType();
|
||||
case Expr::MLV_LValueCast:
|
||||
Diag(loc, diag::err_typecheck_lvalue_casts_not_supported,
|
||||
lex->getSourceRange());
|
||||
return QualType();
|
||||
case Expr::MLV_InvalidExpression:
|
||||
Diag(loc, diag::err_typecheck_expression_not_modifiable_lvalue,
|
||||
lex->getSourceRange());
|
||||
|
|
|
@ -30,7 +30,7 @@ int test1() {
|
|||
|
||||
int test2(double (^S)()) {
|
||||
double (^I)(int) = (void*) S;
|
||||
(void*)I = (void *)S; // expected-error {{expression is not assignable}}
|
||||
(void*)I = (void *)S; // expected-error {{assignment to cast is illegal, lvalue casts are not supported}}
|
||||
|
||||
void *pv = I;
|
||||
|
||||
|
|
|
@ -24,3 +24,8 @@ void test4() {
|
|||
var = -5;
|
||||
}
|
||||
|
||||
// rdar://6319320
|
||||
void test5(int *X, float *P) {
|
||||
(float*)X = P; // expected-error {{assignment to cast is illegal, lvalue casts are not supported}}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue