replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use early continue. Style fix. No functionality change. 

llvm-svn: 195106
This commit is contained in:
Rui Ueyama 2013-11-19 06:10:13 +00:00
parent d52cfdc9ab
commit 9a01d155b6
2 changed files with 29 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lld/include/lld/Core/Pass.h
View File

@ -75,6 +75,9 @@ public:
/// it will call this method to add all the stub (and support) atoms to the
/// master file object.
virtual void addStubAtoms(MutableFile &masterFile) = 0;
private:
void replaceCalleeWithStub(const Atom *target, const Reference *ref);
};
/// Pass for adding GOT entries for pointers to functions/data

52
lld/lib/Passes/StubsPass.cpp
View File

@ -25,42 +25,42 @@ namespace lld {
void StubsPass::perform(std::unique_ptr<MutableFile> &mergedFile) {
// Skip this pass if output format uses text relocations instead of stubs.
if ( ! this->noTextRelocs() )
if (!this->noTextRelocs())
return;
// Scan all references in all atoms.
for (const DefinedAtom *atom : mergedFile->defined()) {
for (const Reference *ref : *atom) {
// Look at call-sites.
if (this->isCallSite(ref->kind()) ) {
const Atom* target = ref->target();
assert(target != nullptr);
bool replaceCalleeWithStub = false;
if ( target->definition() == Atom::definitionSharedLibrary ) {
// Calls to shared libraries go through stubs.
replaceCalleeWithStub = true;
}
else if (const DefinedAtom* defTarget =
dyn_cast<DefinedAtom>(target)) {
if ( defTarget->interposable() != DefinedAtom::interposeNo ) {
// Calls to interposable functions in same linkage unit
// must also go through a stub.
assert(defTarget->scope() != DefinedAtom::scopeTranslationUnit);
replaceCalleeWithStub = true;
}
}
if ( replaceCalleeWithStub ) {
// Make file-format specific stub and other support atoms.
const DefinedAtom* stub = this->getStub(*target);
assert(stub != nullptr);
// Switch call site to reference stub atom instead.
(const_cast<Reference*>(ref))->setTarget(stub);
}
if (!this->isCallSite(ref->kind()))
continue;
const Atom *target = ref->target();
assert(target != nullptr);
if (target->definition() == Atom::definitionSharedLibrary) {
// Calls to shared libraries go through stubs.
replaceCalleeWithStub(target, ref);
continue;
}
const DefinedAtom *defTarget = dyn_cast<DefinedAtom>(target);
if (defTarget && defTarget->interposable() != DefinedAtom::interposeNo) {
// Calls to interposable functions in same linkage unit must also go
// through a stub.
assert(defTarget->scope() != DefinedAtom::scopeTranslationUnit);
replaceCalleeWithStub(target, ref);
}
}
}
// Add all created stubs and support Atoms.
this->addStubAtoms(*mergedFile);
}
void StubsPass::replaceCalleeWithStub(const Atom *target,
const Reference *ref) {
// Make file-format specific stub and other support atoms.
const DefinedAtom *stub = this->getStub(*target);
assert(stub != nullptr);
// Switch call site to reference stub atom instead.
const_cast<Reference *>(ref)->setTarget(stub);
}
} // end namespace lld