[OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.
Summary: If the variable is constrcutible, its copy is created by calling a constructor. Such variables are duplicated and thus, must be captured. Reviewers: jdoerfert Subscribers: yaxunl, guansong, cfe-commits, sstefan1, caomhin Tags: #clang Differential Revision: https://reviews.llvm.org/D83909
This commit is contained in:
parent
c332a984ae
commit
9840208db6
|
@ -2244,7 +2244,11 @@ OpenMPClauseKind Sema::isOpenMPPrivateDecl(ValueDecl *D, unsigned Level,
|
|||
[](OpenMPDirectiveKind K) { return isOpenMPTaskingDirective(K); },
|
||||
Level)) {
|
||||
bool IsTriviallyCopyable =
|
||||
D->getType().getNonReferenceType().isTriviallyCopyableType(Context);
|
||||
D->getType().getNonReferenceType().isTriviallyCopyableType(Context) &&
|
||||
!D->getType()
|
||||
.getNonReferenceType()
|
||||
.getCanonicalType()
|
||||
->getAsCXXRecordDecl();
|
||||
OpenMPDirectiveKind DKind = DSAStack->getDirective(Level);
|
||||
SmallVector<OpenMPDirectiveKind, 4> CaptureRegions;
|
||||
getOpenMPCaptureRegions(CaptureRegions, DKind);
|
||||
|
|
|
@ -229,4 +229,20 @@ struct S {
|
|||
// CHECK: br label %
|
||||
// CHECK: ret i32 0
|
||||
|
||||
class St {
|
||||
public:
|
||||
operator int();
|
||||
St &operator+=(int);
|
||||
};
|
||||
|
||||
// CHECK-LABEL: taskloop_with_class
|
||||
void taskloop_with_class() {
|
||||
St s1;
|
||||
// CHECK: [[TD:%.+]] = call i8* @__kmpc_omp_task_alloc(%struct.ident_t* @{{.+}}, i32 [[GTID:%.+]], i32 1, i64 88, i64 8, i32 (i32, i8*)* bitcast (i32 (i32, [[TD_TYPE:%.+]]*)* @{{.+}} to i32 (i32, i8*)*))
|
||||
// CHECK: call void @__kmpc_taskloop(%struct.ident_t* @{{.+}}, i32 [[GTID]], i8* [[TD]], i32 1, i64* %{{.+}}, i64* %{{.+}}, i64 %{{.+}}, i32 1, i32 0, i64 0, i8* bitcast (void ([[TD_TYPE]]*, [[TD_TYPE]]*, i32)* @{{.+}} to i8*))
|
||||
#pragma omp taskloop
|
||||
for (St s = St(); s < s1; s += 1) {
|
||||
}
|
||||
}
|
||||
|
||||
#endif
|
||||
|
|
Loading…
Reference in New Issue