replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The Thumb2 RFE instructions need to have their second halfword fully specified. 

In addition, the base register is not rGPR, but GPR with th exception that:

    if n == 15 then UNPREDICTABLE

rdar://problem/9273836

llvm-svn: 129391
This commit is contained in:
Johnny Chen 2011-04-12 21:41:51 +00:00
parent c49df2c05a
commit 960eef3db3
3 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/lib/Target/ARM/ARMInstrThumb2.td
View File

@ -3228,19 +3228,20 @@ class T2RFE<bits<12> op31_20, dag oops, dag iops, InstrItinClass itin,
bits<4> Rn;
let Inst{19-16} = Rn;
let Inst{15-0} = 0xc000;
}
def t2RFEDBW : T2RFE<0b111010000011,
(outs), (ins rGPR:$Rn), NoItinerary, "rfedb", "\t$Rn!",
(outs), (ins GPR:$Rn), NoItinerary, "rfedb", "\t$Rn!",
[/* For disassembly only; pattern left blank */]>;
def t2RFEDB : T2RFE<0b111010000001,
(outs), (ins rGPR:$Rn), NoItinerary, "rfeab", "\t$Rn",
(outs), (ins GPR:$Rn), NoItinerary, "rfedb", "\t$Rn",
[/* For disassembly only; pattern left blank */]>;
def t2RFEIAW : T2RFE<0b111010011011,
(outs), (ins rGPR:$Rn), NoItinerary, "rfeia", "\t$Rn!",
(outs), (ins GPR:$Rn), NoItinerary, "rfeia", "\t$Rn!",
[/* For disassembly only; pattern left blank */]>;
def t2RFEIA : T2RFE<0b111010011001,
(outs), (ins rGPR:$Rn), NoItinerary, "rfeia", "\t$Rn",
(outs), (ins GPR:$Rn), NoItinerary, "rfeia", "\t$Rn",
[/* For disassembly only; pattern left blank */]>;
//===----------------------------------------------------------------------===//

8
llvm/lib/Target/ARM/Disassembler/ThumbDisassemblerCore.h
View File

@ -1142,8 +1142,12 @@ static bool DisassembleThumb2SRS(MCInst &MI, unsigned Opcode, uint32_t insn,
// t2RFE[IA|DB]W/t2RFE[IA|DB]: Rn
static bool DisassembleThumb2RFE(MCInst &MI, unsigned Opcode, uint32_t insn,
unsigned short NumOps, unsigned &NumOpsAdded, BO B) {
MI.addOperand(MCOperand::CreateReg(getRegisterEnum(B, ARM::GPRRegClassID,
decodeRn(insn))));
unsigned Rn = decodeRn(insn);
if (Rn == 15) {
DEBUG(errs() << "if n == 15 then UNPREDICTABLE\n");
return false;
}
MI.addOperand(MCOperand::CreateReg(getRegisterEnum(B,ARM::GPRRegClassID,Rn)));
NumOpsAdded = 1;
return true;
}

3
llvm/test/MC/Disassembler/ARM/thumb-tests.txt
View File

@ -238,3 +238,6 @@
# CHECK: svc #230
0xe6 0xdf
# CHECK: rfedb lr
0x1e 0xe8 0x00 0xc0