replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "[GlobalISel] Introduce a generic floating point floor opcode, G_FFLOOR" 

This reverts commit b05ecba6d687fcb3078509220c67458bf1d77a2e.

Apparently adding floor breaks AMDGPU somehow, so I have to back this out
while I look into it.

llvm-svn: 353065
This commit is contained in:
Jessica Paquette 2019-02-04 17:32:47 +00:00
parent 834bded9d6
commit 92834ffcbf
4 changed files with 1 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/include/llvm/Support/TargetOpcodes.def
View File

@ -529,9 +529,6 @@ HANDLE_TARGET_OPCODE(G_FSIN)
/// Floating point square root.
HANDLE_TARGET_OPCODE(G_FSQRT)
/// Floating point floor.
HANDLE_TARGET_OPCODE(G_FFLOOR)
/// Generic AddressSpaceCast.
HANDLE_TARGET_OPCODE(G_ADDRSPACE_CAST)

7
llvm/include/llvm/Target/GenericOpcodes.td
View File

@ -579,13 +579,6 @@ def G_FSQRT : GenericInstruction {
let hasSideEffects = 0;
}
// Floating point floor of a value.
def G_FFLOOR : GenericInstruction {
let OutOperandList = (outs type0:$dst);
let InOperandList = (ins type0:$src1);
let hasSideEffects = 0;
}
//------------------------------------------------------------------------------
// Opcodes for LLVM Intrinsics
//------------------------------------------------------------------------------

1
llvm/include/llvm/Target/GlobalISel/SelectionDAGCompat.td
View File

@ -93,7 +93,6 @@ def : GINodeEquiv<G_FCOS, fcos>;
def : GINodeEquiv<G_FSIN, fsin>;
def : GINodeEquiv<G_FABS, fabs>;
def : GINodeEquiv<G_FSQRT, fsqrt>;
def : GINodeEquiv<G_FFLOOR, ffloor>;
// Broadly speaking G_LOAD is equivalent to ISD::LOAD but there are some
// complications that tablegen must take care of. For example, Predicates such

5
llvm/test/CodeGen/AArch64/GlobalISel/legalizer-info-validation.mir
View File

@ -340,10 +340,7 @@
# DEBUG: .. the first uncovered type index: 1, OK
#
# DEBUG-NEXT: G_FSQRT (opcode {{[0-9]+}}): 1 type index
# DEBUG: .. type index coverage check SKIPPED: user-defined predicate detected
#
# DEBUG-NEXT: G_FFLOOR (opcode {{[0-9]+}}): 1 type index
# DEBUG: .. type index coverage check SKIPPED: no rules defined
# DEBUG: .. the first uncovered type index: 1, OK
# CHECK-NOT: ill-defined