Remove an extra is_directory call.

I checked that opening a directory on windows does fail, so this saves a "stat".

llvm-svn: 186345
This commit is contained in:
Rafael Espindola 2013-07-15 20:52:01 +00:00
parent 1c682f0f0c
commit 8ea26d6a80
1 changed files with 0 additions and 11 deletions

View File

@ -253,17 +253,6 @@ error_code MemoryBuffer::getFile(const char *Filename,
OwningPtr<MemoryBuffer> &result,
int64_t FileSize,
bool RequiresNullTerminator) {
// FIXME: Review if this check is unnecessary on windows as well.
#ifdef LLVM_ON_WIN32
// First check that the "file" is not a directory
bool is_dir = false;
error_code err = sys::fs::is_directory(Filename, is_dir);
if (err)
return err;
if (is_dir)
return make_error_code(errc::is_a_directory);
#endif
int OpenFlags = O_RDONLY;
#ifdef O_BINARY
OpenFlags |= O_BINARY; // Open input file in binary mode on win32.