[PDB] Check the result of setLoadAddress()
Summary: Change setLoadAddress() to return true or false on failure. Reviewers: zturner, llvm-commits Reviewed By: zturner Differential Revision: https://reviews.llvm.org/D43638 llvm-svn: 325843
This commit is contained in:
parent
ba02f3f242
commit
89a19ac38d
|
@ -30,7 +30,7 @@ public:
|
||||||
std::unique_ptr<IPDBSession> &Session);
|
std::unique_ptr<IPDBSession> &Session);
|
||||||
|
|
||||||
uint64_t getLoadAddress() const override;
|
uint64_t getLoadAddress() const override;
|
||||||
void setLoadAddress(uint64_t Address) override;
|
bool setLoadAddress(uint64_t Address) override;
|
||||||
std::unique_ptr<PDBSymbolExe> getGlobalScope() override;
|
std::unique_ptr<PDBSymbolExe> getGlobalScope() override;
|
||||||
std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const override;
|
std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const override;
|
||||||
|
|
||||||
|
|
|
@ -28,7 +28,7 @@ public:
|
||||||
virtual ~IPDBSession();
|
virtual ~IPDBSession();
|
||||||
|
|
||||||
virtual uint64_t getLoadAddress() const = 0;
|
virtual uint64_t getLoadAddress() const = 0;
|
||||||
virtual void setLoadAddress(uint64_t Address) = 0;
|
virtual bool setLoadAddress(uint64_t Address) = 0;
|
||||||
virtual std::unique_ptr<PDBSymbolExe> getGlobalScope() = 0;
|
virtual std::unique_ptr<PDBSymbolExe> getGlobalScope() = 0;
|
||||||
virtual std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const = 0;
|
virtual std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const = 0;
|
||||||
|
|
||||||
|
|
|
@ -49,7 +49,7 @@ public:
|
||||||
SymIndexId findSymbolByTypeIndex(codeview::TypeIndex TI);
|
SymIndexId findSymbolByTypeIndex(codeview::TypeIndex TI);
|
||||||
|
|
||||||
uint64_t getLoadAddress() const override;
|
uint64_t getLoadAddress() const override;
|
||||||
void setLoadAddress(uint64_t Address) override;
|
bool setLoadAddress(uint64_t Address) override;
|
||||||
std::unique_ptr<PDBSymbolExe> getGlobalScope() override;
|
std::unique_ptr<PDBSymbolExe> getGlobalScope() override;
|
||||||
std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const override;
|
std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const override;
|
||||||
|
|
||||||
|
|
|
@ -148,8 +148,8 @@ uint64_t DIASession::getLoadAddress() const {
|
||||||
return (success) ? LoadAddress : 0;
|
return (success) ? LoadAddress : 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
void DIASession::setLoadAddress(uint64_t Address) {
|
bool DIASession::setLoadAddress(uint64_t Address) {
|
||||||
Session->put_loadAddress(Address);
|
return (S_OK == Session->put_loadAddress(Address));
|
||||||
}
|
}
|
||||||
|
|
||||||
std::unique_ptr<PDBSymbolExe> DIASession::getGlobalScope() {
|
std::unique_ptr<PDBSymbolExe> DIASession::getGlobalScope() {
|
||||||
|
|
|
@ -165,7 +165,7 @@ SymIndexId NativeSession::findSymbolByTypeIndex(codeview::TypeIndex Index) {
|
||||||
|
|
||||||
uint64_t NativeSession::getLoadAddress() const { return 0; }
|
uint64_t NativeSession::getLoadAddress() const { return 0; }
|
||||||
|
|
||||||
void NativeSession::setLoadAddress(uint64_t Address) {}
|
bool NativeSession::setLoadAddress(uint64_t Address) { return false; }
|
||||||
|
|
||||||
std::unique_ptr<PDBSymbolExe> NativeSession::getGlobalScope() {
|
std::unique_ptr<PDBSymbolExe> NativeSession::getGlobalScope() {
|
||||||
const auto Id = static_cast<SymIndexId>(SymbolCache.size());
|
const auto Id = static_cast<SymIndexId>(SymbolCache.size());
|
||||||
|
|
|
@ -63,7 +63,7 @@ namespace {
|
||||||
|
|
||||||
class MockSession : public IPDBSession {
|
class MockSession : public IPDBSession {
|
||||||
uint64_t getLoadAddress() const override { return 0; }
|
uint64_t getLoadAddress() const override { return 0; }
|
||||||
void setLoadAddress(uint64_t Address) override {}
|
bool setLoadAddress(uint64_t Address) override { return false; }
|
||||||
std::unique_ptr<PDBSymbolExe> getGlobalScope() override { return nullptr; }
|
std::unique_ptr<PDBSymbolExe> getGlobalScope() override { return nullptr; }
|
||||||
std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const override {
|
std::unique_ptr<PDBSymbol> getSymbolById(uint32_t SymbolId) const override {
|
||||||
return nullptr;
|
return nullptr;
|
||||||
|
|
Loading…
Reference in New Issue