From 896cb661667ba4ef2ac3e6744dfac53c4a80db91 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Wed, 18 Mar 2009 03:02:22 +0000 Subject: [PATCH] Driver: I was too hasty in free'ing Actions, we sometimes share Actions so a simple tree traversal isn't quite good enough. Leaving a FIXME for now. llvm-svn: 67161 --- clang/lib/Driver/Action.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/clang/lib/Driver/Action.cpp b/clang/lib/Driver/Action.cpp index 71bf22ffa12d..cabc33eaec28 100644 --- a/clang/lib/Driver/Action.cpp +++ b/clang/lib/Driver/Action.cpp @@ -13,9 +13,8 @@ using namespace clang::driver; Action::~Action() { - // Free the inputs. - for (iterator it = begin(), ie = end(); it != ie; ++it) - delete *it; + // FIXME: Free the inputs. The problem is that BindArchAction shares + // inputs; so we can't just walk the inputs. } const char *Action::getClassName(ActionClass AC) {