replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[dsymutil] Avoid calling getStringTableData() for each symbol. NFC. 

llvm-svn: 224360
This commit is contained in:
Frederic Riss 2014-12-16 20:21:34 +00:00
parent 5d3280c7a7
commit 896b2c53ba
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/tools/dsymutil/MachODebugMapParser.cpp
View File

@ -36,6 +36,7 @@ private:
object::OwningBinary<object::MachOObjectFile> MainOwningBinary;
/// Map of the binary symbol addresses.
StringMap<uint64_t> MainBinarySymbolAddresses;
StringRef MainBinaryStrings;
/// The constructed DebugMap.
std::unique_ptr<DebugMap> Result;
@ -121,6 +122,7 @@ ErrorOr<std::unique_ptr<DebugMap>> MachODebugMapParser::parse() {
loadMainBinarySymbols();
Result = make_unique<DebugMap>();
const auto &MainBinary = *MainOwningBinary.getBinary();
MainBinaryStrings = MainBinary.getStringTableData();
for (const SymbolRef &Symbol : MainBinary.symbols()) {
const DataRefImpl &DRI = Symbol.getRawDataRefImpl();
if (MainBinary.is64Bit())
@ -142,8 +144,7 @@ void MachODebugMapParser::handleStabSymbolTableEntry(uint32_t StringIndex,
if (!(Type & MachO::N_STAB))
return;
const MachOObjectFile &MachOBinary = *MainOwningBinary.getBinary();
const char *Name = &MachOBinary.getStringTableData().data()[StringIndex];
const char *Name = &MainBinaryStrings.data()[StringIndex];
// An N_OSO entry represents the start of a new object file description.
if (Type == MachO::N_OSO)