Use WeakVH to hold dead mdnodes. Check use_empty() before deleting a node.

llvm-svn: 80928
This commit is contained in:
Devang Patel 2009-09-03 17:03:47 +00:00
parent 728a81ab18
commit 85dac4771f
1 changed files with 7 additions and 5 deletions

View File

@ -17,6 +17,7 @@
#include "llvm/Constants.h"
#include "llvm/Instruction.h"
#include "llvm/Support/ManagedStatic.h"
#include "llvm/Support/ValueHandle.h"
#include "LLVMContextImpl.h"
#include <set>
@ -45,24 +46,25 @@ GetElementPtrConstantExpr::GetElementPtrConstantExpr
}
bool LLVMContext::RemoveDeadMetadata() {
std::vector<const MDNode *> DeadMDNodes;
std::vector<WeakVH> DeadMDNodes;
bool Changed = false;
while (1) {
for (FoldingSet<MDNode>::iterator
I = pImpl->MDNodeSet.begin(),
E = pImpl->MDNodeSet.end(); I != E; ++I) {
const MDNode *N = &(*I);
MDNode *N = &(*I);
if (N->use_empty())
DeadMDNodes.push_back(N);
DeadMDNodes.push_back(WeakVH(N));
}
if (DeadMDNodes.empty())
return Changed;
while (!DeadMDNodes.empty()) {
const MDNode *N = DeadMDNodes.back(); DeadMDNodes.pop_back();
delete N;
const MDNode *N = cast<MDNode>(DeadMDNodes.back()); DeadMDNodes.pop_back();
if (N->use_empty())
delete N;
}
}
return Changed;