replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove call to isSEL and isSEL itself since the call is dead (isObjCObjectPointerType() will never return true for selectors). 

llvm-svn: 54034
This commit is contained in:
Ted Kremenek 2008-07-25 18:17:35 +00:00
parent ec8996d771
commit 83ec24501e
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
clang/lib/Analysis/CheckObjCDealloc.cpp
View File

@ -42,13 +42,6 @@ static bool scan_dealloc(Stmt* S, Selector Dealloc) {
return false;
}
static bool isSEL(QualType T, IdentifierInfo* SelII) {
if (const TypedefType* Ty = T->getAsTypedefType())
return Ty->getDecl()->getIdentifier() == SelII;
return false;
}
void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
const LangOptions& LOpts, BugReporter& BR) {
@ -63,7 +56,6 @@ void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
// http://llvm.org/bugs/show_bug.cgi?id=2517
bool containsPointerIvar = false;
IdentifierInfo* SelII = &Ctx.Idents.get("SEL");
for (ObjCInterfaceDecl::ivar_iterator I=ID->ivar_begin(), E=ID->ivar_end();
I!=E; ++I) {
@ -72,8 +64,7 @@ void clang::CheckObjCDealloc(ObjCImplementationDecl* D,
QualType T = ID->getType();
if (!Ctx.isObjCObjectPointerType(T) ||
ID->getAttr<IBOutletAttr>() || // Skip IBOutlets.
isSEL(T, SelII)) // Skip SEL ivars.
ID->getAttr<IBOutletAttr>()) // Skip IBOutlets.
continue;
containsPointerIvar = true;