replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[PM] Normalize FIXMEs for missing PreserveCFG to have the same wording. 

llvm-svn: 273974
This commit is contained in:
Michael Kuperstein 2016-06-28 00:54:12 +00:00
parent 6c138ce31c
commit 835facd863
9 changed files with 9 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
View File

@ -3111,7 +3111,7 @@ PreservedAnalyses InstCombinePass::run(Function &F,
return PreservedAnalyses::all();
// Mark all the analyses that instcombine updates as preserved.
// FIXME: Need a way to preserve CFG analyses here!
// FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<DominatorTreeAnalysis>();
return PA;

3
llvm/lib/Transforms/Scalar/ADCE.cpp
View File

@ -149,8 +149,7 @@ PreservedAnalyses ADCEPass::run(Function &F, FunctionAnalysisManager &) {
if (!aggressiveDCE(F))
return PreservedAnalyses::all();
// FIXME: ADCE should also 'preserve the CFG'.
// The new pass manager has currently no way to do it.
// FIXME: This should also 'preserve the CFG'.
auto PA = PreservedAnalyses();
PA.preserve<GlobalsAA>();
return PA;

3
llvm/lib/Transforms/Scalar/BDCE.cpp
View File

@ -74,8 +74,7 @@ PreservedAnalyses BDCEPass::run(Function &F, FunctionAnalysisManager &AM) {
if (!bitTrackingDCE(F, DB))
return PreservedAnalyses::all();
// FIXME: BDCE should also 'preserve the CFG'.
// The new pass manager has currently no way to do it.
// FIXME: This should also 'preserve the CFG'.
auto PA = PreservedAnalyses();
PA.preserve<GlobalsAA>();
return PA;

2
llvm/lib/Transforms/Scalar/Float2Int.cpp
View File

@ -532,7 +532,7 @@ PreservedAnalyses Float2IntPass::run(Function &F, FunctionAnalysisManager &) {
if (!runImpl(F))
return PreservedAnalyses::all();
else {
//FIXME: setPreservesCFG is not currently supported in the new PM.
// FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<GlobalsAA>();
return PA;

3
llvm/lib/Transforms/Scalar/IndVarSimplify.cpp
View File

@ -2233,8 +2233,7 @@ PreservedAnalyses IndVarSimplifyPass::run(Loop &L, AnalysisManager<Loop> &AM) {
if (!IVS.run(&L))
return PreservedAnalyses::all();
// FIXME: once we have an equivalent of AU.setPreservesCFG() in the
// new pass manager, we should use that here.
// FIXME: This should also 'preserve the CFG'.
return getLoopPassPreservedAnalyses();
}

3
llvm/lib/Transforms/Scalar/MergedLoadStoreMotion.cpp
View File

@ -595,8 +595,7 @@ MergedLoadStoreMotionPass::run(Function &F, AnalysisManager<Function> &AM) {
if (!Impl.run(F, MD, AA))
return PreservedAnalyses::all();
// FIXME: This pass should also 'preserve the CFG'.
// The new pass manager has currently no way to do it.
// FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<GlobalsAA>();
PA.preserve<MemoryDependenceAnalysis>();

3
llvm/lib/Transforms/Scalar/Reassociate.cpp
View File

@ -2226,8 +2226,7 @@ PreservedAnalyses ReassociatePass::run(Function &F, FunctionAnalysisManager &) {
ValueRankMap.clear();
if (MadeChange) {
// FIXME: Reassociate should also 'preserve the CFG'.
// The new pass manager has currently no way to do it.
// FIXME: This should also 'preserve the CFG'.
auto PA = PreservedAnalyses();
PA.preserve<GlobalsAA>();
return PA;

3
llvm/lib/Transforms/Utils/LCSSA.cpp
View File

@ -340,8 +340,7 @@ PreservedAnalyses LCSSAPass::run(Function &F, AnalysisManager<Function> &AM) {
if (!formLCSSAOnAllLoops(&LI, DT, SE))
return PreservedAnalyses::all();
// FIXME: There is no setPreservesCFG in the new PM. When that becomes
// available, it should be used here.
// FIXME: This should also 'preserve the CFG'.
PreservedAnalyses PA;
PA.preserve<BasicAA>();
PA.preserve<GlobalsAA>();

6
llvm/lib/Transforms/Utils/Mem2Reg.cpp
View File

@ -59,11 +59,7 @@ PreservedAnalyses PromotePass::run(Function &F, AnalysisManager<Function> &AM) {
if (!promoteMemoryToRegister(F, DT, AC))
return PreservedAnalyses::all();
// FIXME: This pass should preserve the CFG.
// There's currently no way to do it in the new PM.
// In the old PM this pass preserved a fair amount of "orthogonal"
// transformation passes. This concept has no sense in the new PM,
// therefore we don't preserve them here.
// FIXME: This should also 'preserve the CFG'.
return PreservedAnalyses::none();
}