replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[LLDB][ELF] Fixup for comments in D67390 

llvm-svn: 371600
This commit is contained in:
Konrad Kleine 2019-09-11 10:12:36 +00:00
parent 3a4781bbf4
commit 813f05915d
3 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/lit/Modules/ELF/load-from-dynsym-alone.test
View File

@ -11,7 +11,7 @@
# 2: 0000000000000000 0 NOTYPE WEAK DEFAULT UND __gmon_start__
# 3: 0000000000401110 13 FUNC GLOBAL DEFAULT 10 functionInDynsym
# We want to keep the symbol "functionInDynsym" in the .dynamic section and not
# We want to keep the symbol "functionInDynsym" in the .dynsym section and not
# have it put the default .symtab section.
# RUN: echo "{functionInDynsym;};" > %T/dynmic-symbols.txt
# RUN: %clang -Wl,--dynamic-list=%T/dynmic-symbols.txt -g -o %t.binary %p/Inputs/load-from-dynsym-alone.c

2
lldb/lit/Modules/ELF/load-symtab-and-dynsym.test
View File

@ -16,7 +16,7 @@
# 0: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND
# 1: 0000000000401110 15 FUNC GLOBAL DEFAULT 10 functionInSymtab
# We want to keep the symbol "functionInDynsym" in the .dynamic section and not
# We want to keep the symbol "functionInDynsym" in the .dynsym section and not
# have it put the default .symtab section.
# RUN: echo "{functionInDynsym;};" > %T/dynmic-symbols.txt
# RUN: %clang -Wl,--dynamic-list=%T/dynmic-symbols.txt -g -o %t.binary %p/Inputs/load-symtab-and-dynsym.c

11
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
View File

@ -2644,12 +2644,11 @@ Symtab *ObjectFileELF::GetSymtab() {
// Sharable objects and dynamic executables usually have 2 distinct symbol
// tables, one named ".symtab", and the other ".dynsym". The dynsym is a
// smaller version of the symtab that only contains global symbols. The
// information found in the dynsym is therefore also found in the symtab,
// while the reverse is not necessarily true.
// One exception to the above rule is when we have minidebuginfo embedded
// into a compressed .gnu_debugdata section. This section contains a .symtab
// from which all symbols already contained in the .dynsym are stripped.
// smaller version of the symtab that only contains global symbols.
// Information in the dynsym section is *usually* also found in the symtab,
// but this is not required as symtab entries can be removed after linking.
// The minidebuginfo format makes use of this facility to create smaller
// symbol tables.
Section *symtab =
section_list->FindSectionByType(eSectionTypeELFSymbolTable, true).get();
if (symtab) {