replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use of vector<bool> causes some horrendous compile time regression (2x)! 

Looks like libstdc++ implementation does not scale very well. Switch back
to using directly managed arrays.

llvm-svn: 29469
This commit is contained in:
Evan Cheng 2006-08-02 09:18:33 +00:00
parent 6025c92e50
commit 8101dd67d1
1 changed files with 26 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
View File

@ -99,7 +99,7 @@ namespace {
: SelectionDAGISel(X86Lowering), : SelectionDAGISel(X86Lowering),
X86Lowering(*TM.getTargetLowering()), X86Lowering(*TM.getTargetLowering()),
Subtarget(&TM.getSubtarget<X86Subtarget>()), Subtarget(&TM.getSubtarget<X86Subtarget>()),
DAGSize(0) {} DAGSize(0), ReachabilityMatrix(NULL), ReachMatrixRange(NULL) {}
virtual bool runOnFunction(Function &Fn) { virtual bool runOnFunction(Function &Fn) {
// Make sure we re-emit a set of the global base reg if necessary // Make sure we re-emit a set of the global base reg if necessary
@ -189,33 +189,35 @@ namespace {
/// ReachabilityMatrix - A N x N matrix representing all pairs reachability /// ReachabilityMatrix - A N x N matrix representing all pairs reachability
/// information. One bit per potential edge. /// information. One bit per potential edge.
std::vector<bool> ReachabilityMatrix; unsigned char *ReachabilityMatrix;
/// RMRange - The range of reachability information available for the /// ReachMatrixRange - The range of reachability information available for
/// particular source node. /// the particular source node.
std::vector<unsigned> ReachMatrixRange; unsigned *ReachMatrixRange;
inline void setReachable(SDNode *f, SDNode *t) { inline void setReachable(SDNode *f, SDNode *t) {
unsigned Idx = f->getNodeId() * DAGSize + t->getNodeId(); unsigned Idx = f->getNodeId() * DAGSize + t->getNodeId();
ReachabilityMatrix[Idx] = true; ReachabilityMatrix[Idx / 8] |= 1 << (Idx % 8);
} }
inline bool isReachable(SDNode *f, SDNode *t) { inline bool isReachable(SDNode *f, SDNode *t) {
unsigned Idx = f->getNodeId() * DAGSize + t->getNodeId(); unsigned Idx = f->getNodeId() * DAGSize + t->getNodeId();
return ReachabilityMatrix[Idx]; return ReachabilityMatrix[Idx / 8] & (1 << (Idx % 8));
} }
/// UnfoldableSet - An boolean array representing nodes which have been /// UnfoldableSet - An boolean array representing nodes which have been
/// folded into addressing modes and therefore should not be folded in /// folded into addressing modes and therefore should not be folded in
/// another operation. /// another operation.
std::vector<bool> UnfoldableSet; unsigned char *UnfoldableSet;
inline void setUnfoldable(SDNode *N) { inline void setUnfoldable(SDNode *N) {
UnfoldableSet[N->getNodeId()] = true; unsigned Id = N->getNodeId();
UnfoldableSet[Id / 8] |= 1 << (Id % 8);
} }
inline bool isUnfoldable(SDNode *N) { inline bool isUnfoldable(SDNode *N) {
return UnfoldableSet[N->getNodeId()]; unsigned Id = N->getNodeId();
return UnfoldableSet[Id / 8] & (1 << (Id % 8));
} }
#ifndef NDEBUG #ifndef NDEBUG
@ -291,9 +293,14 @@ void X86DAGToDAGISel::InstructionSelectBasicBlock(SelectionDAG &DAG) {
TopOrder = DAG.AssignTopologicalOrder(); TopOrder = DAG.AssignTopologicalOrder();
DAGSize = TopOrder.size(); DAGSize = TopOrder.size();
ReachabilityMatrix.assign(DAGSize*DAGSize, false); unsigned RMSize = (DAGSize * DAGSize + 7) / 8;
ReachMatrixRange.assign(DAGSize, 0); ReachabilityMatrix = new unsigned char[RMSize];
UnfoldableSet.assign(DAGSize, false); memset(ReachabilityMatrix, 0, RMSize);
ReachMatrixRange = new unsigned[DAGSize];
memset(ReachMatrixRange, 0, DAGSize * sizeof(unsigned));
unsigned NumBytes = (DAGSize + 7) / 8;
UnfoldableSet = new unsigned char[NumBytes];
memset(UnfoldableSet, 0, NumBytes);
// Codegen the basic block. // Codegen the basic block.
#ifndef NDEBUG #ifndef NDEBUG
@ -305,6 +312,12 @@ void X86DAGToDAGISel::InstructionSelectBasicBlock(SelectionDAG &DAG) {
DEBUG(std::cerr << "===== Instruction selection ends:\n"); DEBUG(std::cerr << "===== Instruction selection ends:\n");
#endif #endif
delete[] ReachabilityMatrix;
delete[] ReachMatrixRange;
delete[] UnfoldableSet;
ReachabilityMatrix = NULL;
ReachMatrixRange = NULL;
UnfoldableSet = NULL;
CodeGenMap.clear(); CodeGenMap.clear();
HandleMap.clear(); HandleMap.clear();
ReplaceMap.clear(); ReplaceMap.clear();