replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Tweak wording of static analyzer diagnostic 

for a block capturing the value of an uninitialized
variable.

llvm-svn: 124212
This commit is contained in:
Ted Kremenek 2011-01-25 19:13:42 +00:00
parent 2d525f08c2
commit 7fd987de23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/StaticAnalyzer/Checkers/UndefCapturedBlockVarChecker.cpp
View File

@ -82,14 +82,14 @@ UndefCapturedBlockVarChecker::PostVisitBlockExpr(CheckerContext &C,
if (state->getSVal(VR).isUndef())
if (ExplodedNode *N = C.generateSink()) {
if (!BT)
BT = new BuiltinBug("Captured block variable is uninitialized");
BT = new BuiltinBug("uninitialized variable captured by block");
// Generate a bug report.
llvm::SmallString<128> buf;
llvm::raw_svector_ostream os(buf);
os << "Variable '" << VD->getName() << "' is captured by block with "
"a garbage value";
os << "Variable '" << VD->getName()
<< "' is uninitialized when captured by block";
EnhancedBugReport *R = new EnhancedBugReport(*BT, os.str(), N);
if (const Expr *Ex = FindBlockDeclRefExpr(BE->getBody(), VD))

4
clang/test/Analysis/blocks.m
View File

@ -73,7 +73,7 @@ void test1(NSString *format, ...) {
void test2() {
static int y = 0;
int x;
^{ y = x + 1; }(); // expected-warning{{Variable 'x' is captured by block with a garbage value}}
^{ y = x + 1; }(); // expected-warning{{Variable 'x' is uninitialized when captured by block}}
}
void test2_b() {
@ -86,5 +86,5 @@ void test2_b() {
void test2_c() {
typedef void (^myblock)(void);
myblock f = ^() { f(); }; // expected-warning{{Variable 'f' is captured by block with a garbage value}}
myblock f = ^() { f(); }; // expected-warning{{Variable 'f' is uninitialized when captured by block}}
}