replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

QoI: -Wreadonly-iboutlet-property should have the warning's location on the property. 

There's no need to refer to the @implementation at all.

Fixes <rdar://problem/13186515>

llvm-svn: 174802
This commit is contained in:
Ted Kremenek 2013-02-09 07:13:16 +00:00
parent 6c29cb3b7a
commit 7ee25676a5
3 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -790,9 +790,9 @@ def warn_undeclared_selector : Warning<
def warn_implicit_atomic_property : Warning< def warn_implicit_atomic_property : Warning<
"property is assumed atomic by default">, InGroup<ImplicitAtomic>, DefaultIgnore; "property is assumed atomic by default">, InGroup<ImplicitAtomic>, DefaultIgnore;
def note_auto_readonly_iboutlet_fixup_suggest : Note< def note_auto_readonly_iboutlet_fixup_suggest : Note<
"readonly IBOutlet property should be changed to be readwrite">; "property should be changed to be readwrite">;
def warn_auto_readonly_iboutlet_property : Warning< def warn_auto_readonly_iboutlet_property : Warning<
"readonly IBOutlet property when auto-synthesized may " "readonly IBOutlet property '%0' when auto-synthesized may "
"not work correctly with 'nib' loader">, "not work correctly with 'nib' loader">,
InGroup<DiagGroup<"readonly-iboutlet-property">>; InGroup<DiagGroup<"readonly-iboutlet-property">>;
def warn_auto_implicit_atomic_property : Warning< def warn_auto_implicit_atomic_property : Warning<

4
clang/lib/Sema/SemaObjCProperty.cpp
View File

@ -861,8 +861,8 @@ Decl *Sema::ActOnPropertyImplDecl(Scope *S,
} }
if (!ReadWriteProperty) { if (!ReadWriteProperty) {
Diag(IC->getLocation(), diag::warn_auto_readonly_iboutlet_property); Diag(property->getLocation(), diag::warn_auto_readonly_iboutlet_property)
Diag(property->getLocation(), diag::note_property_declare); << property->getName();
SourceLocation readonlyLoc; SourceLocation readonlyLoc;
if (LocPropertyAttribute(Context, "readonly", if (LocPropertyAttribute(Context, "readonly",
property->getLParenLoc(), readonlyLoc)) { property->getLParenLoc(), readonlyLoc)) {

14
clang/test/SemaObjC/iboutlet.m
View File

@ -9,17 +9,15 @@
#define IBOutlet __attribute__((iboutlet)) #define IBOutlet __attribute__((iboutlet))
@interface I @interface I
@property (getter = MyGetter, readonly, assign) IBOutlet NSView *myView; // expected-note {{property declared here}} \ @property (getter = MyGetter, readonly, assign) IBOutlet NSView *myView; // expected-warning {{readonly IBOutlet property 'myView' when auto-synthesized may not work correctly with 'nib' loader}} expected-note {{property should be changed to be readwrite}}
// expected-note {{readonly IBOutlet property should be changed to be readwrite}}
@property (readonly) IBOutlet NSView *myView1; // expected-note {{readonly IBOutlet property should be changed to be readwrite}} \ @property (readonly) IBOutlet NSView *myView1; // expected-warning {{readonly IBOutlet property 'myView1' when auto-synthesized may not work correctly with 'nib' loader}} expected-note {{property should be changed to be readwrite}}
// expected-note {{property declared here}}
@property (getter = MyGetter, READONLY) IBOutlet NSView *myView2; // expected-note {{property declared here}} @property (getter = MyGetter, READONLY) IBOutlet NSView *myView2; // expected-warning {{readonly IBOutlet property 'myView2' when auto-synthesized may not work correctly with 'nib' loader}}
@end @end
@implementation I // expected-warning 3 {{readonly IBOutlet property when auto-synthesized may not work correctly with 'nib' loader}} @implementation I
@end @end
@ -29,7 +27,7 @@
@interface NSObject @end @interface NSObject @end
@interface RKTFHView : NSObject @interface RKTFHView : NSObject
@property( readonly ) __attribute__((iboutlet)) UILabel *autoReadOnlyReadOnly; // expected-note {{property declared here}} expected-note {{readonly IBOutlet property should be changed to be readwrite}} @property( readonly ) __attribute__((iboutlet)) UILabel *autoReadOnlyReadOnly; // expected-warning {{readonly IBOutlet property 'autoReadOnlyReadOnly' when auto-synthesized may not work correctly with 'nib' loader}} expected-note {{property should be changed to be readwrite}}
@property( readonly ) __attribute__((iboutlet)) UILabel *autoReadOnlyReadWrite; @property( readonly ) __attribute__((iboutlet)) UILabel *autoReadOnlyReadWrite;
@property( readonly ) __attribute__((iboutlet)) UILabel *synthReadOnlyReadWrite; @property( readonly ) __attribute__((iboutlet)) UILabel *synthReadOnlyReadWrite;
@end @end
@ -39,6 +37,6 @@
@property( readwrite ) __attribute__((iboutlet)) UILabel *synthReadOnlyReadWrite; @property( readwrite ) __attribute__((iboutlet)) UILabel *synthReadOnlyReadWrite;
@end @end
@implementation RKTFHView // expected-warning {{readonly IBOutlet property when auto-synthesized may not work correctly with 'nib' loader}} @implementation RKTFHView
@synthesize synthReadOnlyReadWrite=_synthReadOnlyReadWrite; @synthesize synthReadOnlyReadWrite=_synthReadOnlyReadWrite;
@end @end