From 7d94c9277a65ae4f5cf8d4460f1aa02575fbb965 Mon Sep 17 00:00:00 2001 From: Argyrios Kyrtzidis Date: Sat, 23 Apr 2011 01:04:12 +0000 Subject: [PATCH] Fix an assertion when code-completing, rdar://9288730 & http://llvm.org/PR9728. llvm-svn: 130042 --- clang/lib/Parse/ParseExprCXX.cpp | 7 ++++++- clang/test/CodeCompletion/PR9728.cpp | 9 +++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 clang/test/CodeCompletion/PR9728.cpp diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp index 49d30741190e..ccc75125ad45 100644 --- a/clang/lib/Parse/ParseExprCXX.cpp +++ b/clang/lib/Parse/ParseExprCXX.cpp @@ -161,7 +161,12 @@ bool Parser::ParseOptionalCXXScopeSpecifier(CXXScopeSpec &SS, // Code completion for a nested-name-specifier, where the code // code completion token follows the '::'. Actions.CodeCompleteQualifiedId(getCurScope(), SS, EnteringContext); - ConsumeCodeCompletionToken(); + SourceLocation ccLoc = ConsumeCodeCompletionToken(); + // Include code completion token into the range of the scope otherwise + // when we try to annotate the scope tokens the dangling code completion + // token will cause assertion in + // Preprocessor::AnnotatePreviousCachedTokens. + SS.setEndLoc(ccLoc); } } diff --git a/clang/test/CodeCompletion/PR9728.cpp b/clang/test/CodeCompletion/PR9728.cpp new file mode 100644 index 000000000000..91f49be91fcf --- /dev/null +++ b/clang/test/CodeCompletion/PR9728.cpp @@ -0,0 +1,9 @@ +namespace N { +struct SFoo; +} + +struct brokenfile_t { + brokenfile_t (N:: + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:6:20 %s -o - | FileCheck %s + // CHECK: SFoo +