In Release modes, Visual Studio complains that the Operator destructor in User.cpp
never returns, which is true by design. Initially assumed that the reason is llvm_unreachable being dependent on NDEBUG. However, even if llvm_unreachable is replaced by __assume(false), VC still warns in Release modes but not in Debug modes... The real reason turned out to be optimization flags. With /Od in Debug modes the warning is not issued whereas with /O1 it is. I could not find any documentation to this effect, but it is reproducable: Try compiling http://msdn.microsoft.com/en-us/library/khwfyc5d(v=vs.90).aspx with /O1 and then with /Od. llvm-svn: 204659
This commit is contained in:
parent
a7f1e0c44f
commit
7b085a4799
|
@ -83,8 +83,28 @@ void User::operator delete(void *Usr) {
|
||||||
// Operator Class
|
// Operator Class
|
||||||
//===----------------------------------------------------------------------===//
|
//===----------------------------------------------------------------------===//
|
||||||
|
|
||||||
|
#if defined(_MSC_VER)
|
||||||
|
// In Release modes, Visual Studio complains that the Operator destructor
|
||||||
|
// never returns, which is true by design.
|
||||||
|
// This does *not* depend on llvm_unreachable being dependent on NDEBUG:
|
||||||
|
// even if llvm_unreachable is replaced by __assume(false), VC still warns in
|
||||||
|
// Release modes but not in Debug modes. The real reason is optimization flags.
|
||||||
|
// With /Od in Debug modes the warning is not issued whereas with /O1 it is.
|
||||||
|
// I could not find any documentation to this effect, it is reproducable:
|
||||||
|
// Try compiling http://msdn.microsoft.com/en-us/library/khwfyc5d(v=vs.90).aspx
|
||||||
|
// with /O1 and then with /Od.
|
||||||
|
// Anyhow, solution is same as lib/Support/Process.cpp:~self_process().
|
||||||
|
|
||||||
|
#pragma warning(push)
|
||||||
|
#pragma warning(disable:4722)
|
||||||
|
#endif
|
||||||
|
|
||||||
Operator::~Operator() {
|
Operator::~Operator() {
|
||||||
llvm_unreachable("should never destroy an Operator");
|
llvm_unreachable("should never destroy an Operator");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#if defined(_MSC_VER)
|
||||||
|
#pragma warning(pop)
|
||||||
|
#endif
|
||||||
|
|
||||||
} // End llvm namespace
|
} // End llvm namespace
|
||||||
|
|
Loading…
Reference in New Issue