replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

<rdar://problem/12389806> 

Have the disassembler's Instruction::Dump always insert at least
one space character between an opcode and its arguments, don't let
a long opcode name abut the arguments.

llvm-svn: 171561
This commit is contained in:
Jason Molenda 2013-01-04 23:52:35 +00:00
parent a49cf10737
commit 7a37c1ec4c
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/source/Core/Disassembler.cpp
View File

@ -541,7 +541,7 @@ Instruction::Dump (lldb_private::Stream *s,
bool show_bytes,
const ExecutionContext* exe_ctx)
{
const size_t opcode_column_width = 7;
size_t opcode_column_width = 7;
const size_t operand_column_width = 25;
CalculateMnemonicOperandsAndCommentIfNeeded (exe_ctx);
@ -584,6 +584,14 @@ Instruction::Dump (lldb_private::Stream *s,
const size_t opcode_pos = ss.GetSize();
// The default opcode size of 7 characters is plenty for most architectures
// but some like arm can pull out the occasional vqrshrun.s16. We won't get
// consistent column spacing in these cases, unfortunately.
if (m_opcode_name.length() >= opcode_column_width)
{
opcode_column_width = m_opcode_name.length() + 1;
}
ss.PutCString (m_opcode_name.c_str());
ss.FillLastLineToColumn (opcode_pos + opcode_column_width, ' ');
ss.PutCString (m_mnemocics.c_str());