From 7a09e88b6eac8c6b02ba02ef6b9c9d260247b7df Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Fri, 24 Jul 2015 18:07:14 +0000 Subject: [PATCH] Fix double implementation of log We need to use M_LOG2E instead of M_LOG2E_F. llvm-svn: 243132 --- libclc/generic/include/clc/math/log.h | 26 ++++++++++++++++++++++--- libclc/generic/include/clc/math/log.inc | 23 ++++++++++++++++++++++ libclc/generic/lib/SOURCES | 1 + libclc/generic/lib/math/log.cl | 26 +++++++++++++++++++++++++ 4 files changed, 73 insertions(+), 3 deletions(-) create mode 100644 libclc/generic/include/clc/math/log.inc create mode 100644 libclc/generic/lib/math/log.cl diff --git a/libclc/generic/include/clc/math/log.h b/libclc/generic/include/clc/math/log.h index ee272eb30d37..5680de2c1e02 100644 --- a/libclc/generic/include/clc/math/log.h +++ b/libclc/generic/include/clc/math/log.h @@ -1,4 +1,24 @@ -#undef log +/* + * Copyright (c) 2015 Advanced Micro Devices, Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ -// log(x) = log2(x) * (1/log2(e)) -#define log(val) (log2(val) * 0.693147181f) +#define __CLC_BODY +#include diff --git a/libclc/generic/include/clc/math/log.inc b/libclc/generic/include/clc/math/log.inc new file mode 100644 index 000000000000..621dd0831b46 --- /dev/null +++ b/libclc/generic/include/clc/math/log.inc @@ -0,0 +1,23 @@ +/* + * Copyright (c) 2015 Advanced Micro Devices, Inc. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to deal + * in the Software without restriction, including without limitation the rights + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + * copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + * THE SOFTWARE. + */ + +_CLC_OVERLOAD _CLC_DECL __CLC_GENTYPE log(__CLC_GENTYPE a); diff --git a/libclc/generic/lib/SOURCES b/libclc/generic/lib/SOURCES index 53959d5560f1..a5ee9f81af85 100644 --- a/libclc/generic/lib/SOURCES +++ b/libclc/generic/lib/SOURCES @@ -91,6 +91,7 @@ math/half_sqrt.cl math/hypot.cl math/clc_ldexp.cl math/ldexp.cl +math/log.cl math/log10.cl math/log1p.cl math/log2.cl diff --git a/libclc/generic/lib/math/log.cl b/libclc/generic/lib/math/log.cl new file mode 100644 index 000000000000..ec1faa12606a --- /dev/null +++ b/libclc/generic/lib/math/log.cl @@ -0,0 +1,26 @@ +#include +#include "../clcmacro.h" + +/* + *log(x) = log2(x) * (1/log2(e)) + */ + +_CLC_OVERLOAD _CLC_DEF float log(float x) +{ + return log2(x) * (1.0f / M_LOG2E_F); +} + +_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, float, log, float); + +#ifdef cl_khr_fp64 + +#pragma OPENCL EXTENSION cl_khr_fp64 : enable + +_CLC_OVERLOAD _CLC_DEF double log(double x) +{ + return log2(x) * (1.0 / M_LOG2E); +} + +_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, log, double); + +#endif // cl_khr_fp64