replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[MemorySSA] Remove restrictive asserts. 

The verification I added has overly restrictive asserts.
Unreachable blocks can have any incoming value in practice, after an
update due to a "replaceAllUses" call when the repalced entry is
LiveOnEntry.

llvm-svn: 369050
This commit is contained in:
Alina Sbirlea 2019-08-15 21:20:08 +00:00
parent 9be6d7edb2
commit 79ff20428e
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Analysis/MemorySSA.cpp
View File

@ -1886,8 +1886,6 @@ void MemorySSA::verifyPrevDefInPhis(Function &F) const {
}
DTNode = DTNode->getIDom();
}
assert((DTNode || IncAcc == getLiveOnEntryDef()) &&
"Expected LoE inc");
} else if (auto *DefList = getBlockDefs(Pred)) {
// If Pred has unreachable predecessors, but has at least a Def, the
// incoming access can be the last Def in Pred, or it could have been
@ -1897,8 +1895,7 @@ void MemorySSA::verifyPrevDefInPhis(Function &F) const {
"Incorrect incoming access into phi.");
} else {
// If Pred has unreachable predecessors and no Defs, incoming access
// should be LoE.
assert(IncAcc == getLiveOnEntryDef() && "Expected LoE inc");
// should be LoE; In practice, after an update, it may be any access.
}
}
}