replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Commit a bit of a hack to fully handle the situation where variables are 

marked explicitly as uninitialized through direct self initialization:

  int x = x;

With r128894 we prevented warnings about this code, and this patch
teaches the analysis engine to continue analyzing subsequent uses of
'x'. This should wrap up PR9624.

There is still an open question of whether we should suppress the
maybe-uninitialized warnings resulting from variables initialized in
this fashion. The definitely-uninitialized uses should always be warned.

llvm-svn: 128932
This commit is contained in:
Chandler Carruth 2011-04-05 21:36:30 +00:00
parent d4e20eacf0
commit 78c7e34485
2 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
clang/lib/Analysis/UninitializedValues.cpp
View File

@ -472,12 +472,24 @@ void TransferFunctions::VisitDeclStmt(DeclStmt *ds) {
DI != DE; ++DI) {
if (VarDecl *vd = dyn_cast<VarDecl>(*DI)) {
if (isTrackedVar(vd)) {
if (Stmt *init = vd->getInit()) {
if (Expr *init = vd->getInit()) {
Visit(init);
vals[vd] = Initialized;
// If the initializer consists solely of a reference to itself, we
// explicitly mark the variable as uninitialized. This allows code
// like the following:
//
// int x = x;
//
// to deliberately leave a variable uninitialized. Different analysis
// clients can detect this pattern and adjust their reporting
// appropriately, but we need to continue to analyze subsequent uses
// of the variable.
DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(init->IgnoreParenImpCasts());
vals[vd] = (DRE && DRE->getDecl() == vd) ? Uninitialized
: Initialized;
}
}
else if (Stmt *init = vd->getInit()) {
} else if (Stmt *init = vd->getInit()) {
Visit(init);
}
}

6
clang/test/Sema/uninit-variables.c
View File

@ -91,8 +91,10 @@ void test14() {
for (;;) {}
}
void test15() {
int x = x; // no-warning: signals intended lack of initialization.
int test15() {
int x = x; // no-warning: signals intended lack of initialization. \
// expected-note{{variable 'x' is declared here}}
return x; // expected-warning{{variable 'x' is possibly uninitialized when used here}}
}
// Don't warn in the following example; shows dataflow confluence.