From 789647686ca4ad39a15c00540f859ebe08ff1460 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Tue, 24 Oct 2017 17:29:12 +0000 Subject: [PATCH] IndirectCallSiteVisitor.h:findIndirectCallSites Don't mark header functions as file-scope static This creates ODR violations if the function is called from another inline function in a header and also creates binary bloat from duplicate definitions. llvm-svn: 316474 --- llvm/include/llvm/Analysis/IndirectCallSiteVisitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/include/llvm/Analysis/IndirectCallSiteVisitor.h b/llvm/include/llvm/Analysis/IndirectCallSiteVisitor.h index 3c40cc0235cc..dde56a143c51 100644 --- a/llvm/include/llvm/Analysis/IndirectCallSiteVisitor.h +++ b/llvm/include/llvm/Analysis/IndirectCallSiteVisitor.h @@ -27,7 +27,7 @@ struct PGOIndirectCallSiteVisitor }; // Helper function that finds all indirect call sites. -static inline std::vector findIndirectCallSites(Function &F) { +inline std::vector findIndirectCallSites(Function &F) { PGOIndirectCallSiteVisitor ICV; ICV.visit(F); return ICV.IndirectCallInsts;