[analyzer] Replace bug category magic strings with shared constants.
One small functionality change is to bring the sizeof-pointer checker in line with the other checkers by making its category be "Logic error" instead of just "Logic". There should be no other functionality changes. Patch by Daniel Marjamäki! llvm-svn: 191910
This commit is contained in:
parent
9db2d9adef
commit
761ee868a5
|
@ -15,6 +15,7 @@ namespace clang {
|
|||
namespace ento {
|
||||
namespace categories {
|
||||
extern const char *CoreFoundationObjectiveC;
|
||||
extern const char *LogicError;
|
||||
extern const char *MemoryCoreFoundationObjectiveC;
|
||||
extern const char *UnixAPI;
|
||||
}
|
||||
|
|
|
@ -15,6 +15,7 @@
|
|||
#define LLVM_CLANG_ANALYSIS_BUGTYPE
|
||||
|
||||
#include "clang/Basic/LLVM.h"
|
||||
#include "clang/StaticAnalyzer/Checkers/CommonBugCategories.h"
|
||||
#include "llvm/ADT/FoldingSet.h"
|
||||
#include <string>
|
||||
|
||||
|
@ -54,10 +55,10 @@ class BuiltinBug : public BugType {
|
|||
const std::string desc;
|
||||
public:
|
||||
BuiltinBug(const char *name, const char *description)
|
||||
: BugType(name, "Logic error"), desc(description) {}
|
||||
: BugType(name, categories::LogicError), desc(description) {}
|
||||
|
||||
BuiltinBug(const char *name)
|
||||
: BugType(name, "Logic error"), desc(name) {}
|
||||
: BugType(name, categories::LogicError), desc(name) {}
|
||||
|
||||
StringRef getDescription() const { return desc; }
|
||||
};
|
||||
|
|
|
@ -231,7 +231,7 @@ ProgramStateRef CStringChecker::checkNonNull(CheckerContext &C,
|
|||
return NULL;
|
||||
|
||||
if (!BT_Null)
|
||||
BT_Null.reset(new BuiltinBug("Unix API",
|
||||
BT_Null.reset(new BuiltinBug(categories::UnixAPI,
|
||||
"Null pointer argument in call to byte string function"));
|
||||
|
||||
SmallString<80> buf;
|
||||
|
@ -525,7 +525,7 @@ void CStringChecker::emitOverlapBug(CheckerContext &C, ProgramStateRef state,
|
|||
return;
|
||||
|
||||
if (!BT_Overlap)
|
||||
BT_Overlap.reset(new BugType("Unix API", "Improper arguments"));
|
||||
BT_Overlap.reset(new BugType(categories::UnixAPI, "Improper arguments"));
|
||||
|
||||
// Generate a report for this bug.
|
||||
BugReport *report =
|
||||
|
@ -702,7 +702,7 @@ SVal CStringChecker::getCStringLength(CheckerContext &C, ProgramStateRef &state,
|
|||
|
||||
if (ExplodedNode *N = C.addTransition(state)) {
|
||||
if (!BT_NotCString)
|
||||
BT_NotCString.reset(new BuiltinBug("Unix API",
|
||||
BT_NotCString.reset(new BuiltinBug(categories::UnixAPI,
|
||||
"Argument is not a null-terminated string."));
|
||||
|
||||
SmallString<120> buf;
|
||||
|
@ -762,7 +762,7 @@ SVal CStringChecker::getCStringLength(CheckerContext &C, ProgramStateRef &state,
|
|||
|
||||
if (ExplodedNode *N = C.addTransition(state)) {
|
||||
if (!BT_NotCString)
|
||||
BT_NotCString.reset(new BuiltinBug("Unix API",
|
||||
BT_NotCString.reset(new BuiltinBug(categories::UnixAPI,
|
||||
"Argument is not a null-terminated string."));
|
||||
|
||||
SmallString<120> buf;
|
||||
|
|
|
@ -65,7 +65,7 @@ void WalkAST::VisitUnaryExprOrTypeTraitExpr(UnaryExprOrTypeTraitExpr *E) {
|
|||
PathDiagnosticLocation::createBegin(E, BR.getSourceManager(), AC);
|
||||
BR.EmitBasicReport(AC->getDecl(),
|
||||
"Potential unintended use of sizeof() on pointer type",
|
||||
"Logic",
|
||||
categories::LogicError,
|
||||
"The code calls sizeof() on a pointer type. "
|
||||
"This can produce an unexpected result.",
|
||||
ELoc, &R, 1);
|
||||
|
|
|
@ -11,6 +11,7 @@
|
|||
namespace clang { namespace ento { namespace categories {
|
||||
|
||||
const char *CoreFoundationObjectiveC = "Core Foundation/Objective-C";
|
||||
const char *LogicError = "Logic error";
|
||||
const char *MemoryCoreFoundationObjectiveC =
|
||||
"Memory (Core Foundation/Objective-C)";
|
||||
const char *UnixAPI = "Unix API";
|
||||
|
|
Loading…
Reference in New Issue