From 75d4a83f2f9db7635e8e268d0524e9dd33a445c0 Mon Sep 17 00:00:00 2001 From: Nick Lewycky Date: Sun, 17 Aug 2008 20:02:02 +0000 Subject: [PATCH] Make this comment clearer. Instead of using an ambiguous ~ (not) on an icmp predicate, swap the order of the operands. llvm-svn: 54907 --- llvm/lib/Transforms/Scalar/InstructionCombining.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp index defad26f8a1c..a517d941c9a9 100644 --- a/llvm/lib/Transforms/Scalar/InstructionCombining.cpp +++ b/llvm/lib/Transforms/Scalar/InstructionCombining.cpp @@ -5830,7 +5830,7 @@ Instruction *InstCombiner::visitICmpInstWithInstAndIntCst(ICmpInst &ICI, ConstantInt::get(RHSV ^ SignBit)); } - // (icmp u/s (xor A ~SignBit), C) -> (icmp ~s/u A, (xor C ~SignBit)) + // (icmp u/s (xor A ~SignBit), C) -> (icmp s/u (xor C ~SignBit), A) if (!ICI.isEquality() && (~XorCST->getValue()).isSignBit()) { const APInt &NotSignBit = XorCST->getValue(); ICmpInst::Predicate Pred = ICI.isSignedPredicate()