replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a LLVM_DUMP_METHOD macro. 

The motivation is to mark dump methods as used in debug builds so that they can
be called from lldb, but to not do so in release builds so that they can be
dead-stripped.

There's lots of potential follow-up work suggested in the thread
"Should dump methods be LLVM_ATTRIBUTE_USED only in debug builds?" on cfe-dev,
but everyone seems to agreen on this subset.

Macro name chosen by fair coin toss.

llvm-svn: 198456
This commit is contained in:
Nico Weber 2014-01-03 22:53:37 +00:00
parent 5b3d51c7fb
commit 7408c7066a
3 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
llvm/include/llvm/Support/Compiler.h
View File

@ -434,4 +434,13 @@
#define LLVM_HAS_INITIALIZER_LISTS 0
#endif
/// \brief Mark debug helper function definitions like dump() that should not be
/// stripped from debug builds.
// FIXME: Move this to a private config.h as it's not usable in public headers.
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
#define LLVM_DUMP_METHOD LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED
#else
#define LLVM_DUMP_METHOD LLVM_ATTRIBUTE_NOINLINE
#endif
#endif

2
llvm/lib/CodeGen/MachineBlockPlacement.cpp
View File

@ -152,7 +152,7 @@ public:
#ifndef NDEBUG
/// \brief Dump the blocks in this chain.
void dump() LLVM_ATTRIBUTE_USED {
LLVM_DUMP_METHOD void dump() {
for (iterator I = begin(), E = end(); I != E; ++I)
(*I)->dump();
}

4
llvm/lib/Transforms/Scalar/SROA.cpp
View File

@ -244,8 +244,8 @@ public:
void printUse(raw_ostream &OS, const_iterator I,
StringRef Indent = " ") const;
void print(raw_ostream &OS) const;
void LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED dump(const_iterator I) const;
void LLVM_ATTRIBUTE_NOINLINE LLVM_ATTRIBUTE_USED dump() const;
LLVM_DUMP_METHOD void dump(const_iterator I) const;
LLVM_DUMP_METHOD void dump() const;
#endif
private: