From 73b98ed8cf2a05e2aabd55eaf1462d981788a955 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 15 May 2014 14:41:54 +0000 Subject: [PATCH] R600/SI: Only use SALU instructions for 64-bit add in a block of CF depth 0 llvm-svn: 208886 --- llvm/lib/Target/R600/AMDGPUISelDAGToDAG.cpp | 11 ++++----- llvm/test/CodeGen/R600/add.ll | 25 +++++++++++++++++++++ 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/llvm/lib/Target/R600/AMDGPUISelDAGToDAG.cpp b/llvm/lib/Target/R600/AMDGPUISelDAGToDAG.cpp index ba705db69ded..f1f0bfa89ac0 100644 --- a/llvm/lib/Target/R600/AMDGPUISelDAGToDAG.cpp +++ b/llvm/lib/Target/R600/AMDGPUISelDAGToDAG.cpp @@ -239,12 +239,13 @@ SDNode *AMDGPUDAGToDAGISel::Select(SDNode *N) { AddLoArgs.push_back(SDValue(Lo0, 0)); AddLoArgs.push_back(SDValue(Lo1, 0)); - SDNode *AddLo = CurDAG->getMachineNode(AMDGPU::S_ADD_I32, DL, - VTList, AddLoArgs); + SDNode *AddLo = CurDAG->getMachineNode( + isCFDepth0() ? AMDGPU::S_ADD_I32 : AMDGPU::V_ADD_I32_e32, + DL, VTList, AddLoArgs); SDValue Carry = SDValue(AddLo, 1); - SDNode *AddHi = CurDAG->getMachineNode(AMDGPU::S_ADDC_U32, DL, - MVT::i32, SDValue(Hi0, 0), - SDValue(Hi1, 0), Carry); + SDNode *AddHi = CurDAG->getMachineNode( + isCFDepth0() ? AMDGPU::S_ADDC_U32 : AMDGPU::V_ADDC_U32_e32, + DL, MVT::i32, SDValue(Hi0, 0), SDValue(Hi1, 0), Carry); SDValue Args[5] = { CurDAG->getTargetConstant(AMDGPU::SReg_64RegClassID, MVT::i32), diff --git a/llvm/test/CodeGen/R600/add.ll b/llvm/test/CodeGen/R600/add.ll index e9db52ae4ae1..711a2bc41774 100644 --- a/llvm/test/CodeGen/R600/add.ll +++ b/llvm/test/CodeGen/R600/add.ll @@ -140,3 +140,28 @@ entry: store i64 %1, i64 addrspace(1)* %out ret void } + +; Test i64 add inside a branch. We don't allow SALU instructions inside of +; branches. +; FIXME: We are being conservative here. We could allow this in some cases. +; FUNC-LABEL: @add64_in_branch +; SI-CHECK-NOT: S_ADD_I32 +; SI-CHECK-NOT: S_ADDC_U32 +define void @add64_in_branch(i64 addrspace(1)* %out, i64 addrspace(1)* %in, i64 %a, i64 %b, i64 %c) { +entry: + %0 = icmp eq i64 %a, 0 + br i1 %0, label %if, label %else + +if: + %1 = load i64 addrspace(1)* %in + br label %endif + +else: + %2 = add i64 %a, %b + br label %endif + +endif: + %3 = phi i64 [%1, %if], [%2, %else] + store i64 %3, i64 addrspace(1)* %out + ret void +}