From 718da0b53b3749ac5edfb90edc9d4f38122ce446 Mon Sep 17 00:00:00 2001 From: Jack Carter Date: Wed, 30 Jan 2013 02:24:33 +0000 Subject: [PATCH] This patch implements runtime ARM specific setting of ELF header e_flags. Contributer: Jack Carter llvm-svn: 173885 --- llvm/include/llvm/Support/ELF.h | 10 +++++++++- llvm/lib/Target/ARM/ARMAsmPrinter.cpp | 11 +++++++++++ llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp | 10 ++++++++++ llvm/test/MC/ARM/elf-eflags-eabi-cg.ll | 13 +++++++++++++ llvm/test/MC/ARM/elf-eflags-eabi.s | 1 - 5 files changed, 43 insertions(+), 2 deletions(-) create mode 100644 llvm/test/MC/ARM/elf-eflags-eabi-cg.ll diff --git a/llvm/include/llvm/Support/ELF.h b/llvm/include/llvm/Support/ELF.h index e35924495eb7..746ea317bd1e 100644 --- a/llvm/include/llvm/Support/ELF.h +++ b/llvm/include/llvm/Support/ELF.h @@ -495,7 +495,15 @@ enum { }; // ARM Specific e_flags -enum { EF_ARM_EABIMASK = 0xFF000000U }; +enum { + EF_ARM_EABI_UNKNOWN = 0x00000000U, + EF_ARM_EABI_VER1 = 0x01000000U, + EF_ARM_EABI_VER2 = 0x02000000U, + EF_ARM_EABI_VER3 = 0x03000000U, + EF_ARM_EABI_VER4 = 0x04000000U, + EF_ARM_EABI_VER5 = 0x05000000U, + EF_ARM_EABIMASK = 0xFF000000U +}; // ELF Relocation types for ARM // Meets 2.08 ABI Specs. diff --git a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp index ee2a2289b15b..397736a2bf38 100644 --- a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp +++ b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp @@ -37,6 +37,7 @@ #include "llvm/MC/MCAsmInfo.h" #include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCContext.h" +#include "llvm/MC/MCELFStreamer.h" #include "llvm/MC/MCInst.h" #include "llvm/MC/MCInstBuilder.h" #include "llvm/MC/MCObjectStreamer.h" @@ -45,6 +46,7 @@ #include "llvm/MC/MCSymbol.h" #include "llvm/Support/CommandLine.h" #include "llvm/Support/Debug.h" +#include "llvm/Support/ELF.h" #include "llvm/Support/ErrorHandling.h" #include "llvm/Support/TargetRegistry.h" #include "llvm/Support/raw_ostream.h" @@ -699,6 +701,15 @@ void ARMAsmPrinter::EmitEndOfAsmFile(Module &M) { // generates code that does this, it is always safe to set. OutStreamer.EmitAssemblerFlag(MCAF_SubsectionsViaSymbols); } + // FIXME: This should eventually end up somewhere else where more + // intelligent flag decisions can be made. For now we are just maintaining + // the status quo for ARM and setting EF_ARM_EABI_VER5 as the default. + if (Subtarget->isTargetELF()) { + if (OutStreamer.hasRawTextSupport()) return; + + MCELFStreamer &MES = static_cast(OutStreamer); + MES.getAssembler().setELFHeaderEFlags(ELF::EF_ARM_EABI_VER5); + } } //===----------------------------------------------------------------------===// diff --git a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp index e9bdc4ad9ba2..77620e92189a 100644 --- a/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp +++ b/llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp @@ -18,7 +18,9 @@ #include "llvm/ADT/StringSwitch.h" #include "llvm/ADT/Twine.h" #include "llvm/MC/MCAsmInfo.h" +#include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCContext.h" +#include "llvm/MC/MCELFStreamer.h" #include "llvm/MC/MCExpr.h" #include "llvm/MC/MCInst.h" #include "llvm/MC/MCInstrDesc.h" @@ -28,6 +30,7 @@ #include "llvm/MC/MCRegisterInfo.h" #include "llvm/MC/MCStreamer.h" #include "llvm/MC/MCSubtargetInfo.h" +#include "llvm/Support/ELF.h" #include "llvm/Support/MathExtras.h" #include "llvm/Support/SourceMgr.h" #include "llvm/Support/TargetRegistry.h" @@ -250,6 +253,13 @@ public: // Not in an ITBlock to start with. ITState.CurPosition = ~0U; + + // Set ELF header flags. + // FIXME: This should eventually end up somewhere else where more + // intelligent flag decisions can be made. For now we are just maintaining + // the status quo for ARM and setting EF_ARM_EABI_VER5 as the default. + MCELFStreamer &MES = static_cast(Parser.getStreamer()); + MES.getAssembler().setELFHeaderEFlags(ELF::EF_ARM_EABI_VER5); } // Implementation of the MCTargetAsmParser interface: diff --git a/llvm/test/MC/ARM/elf-eflags-eabi-cg.ll b/llvm/test/MC/ARM/elf-eflags-eabi-cg.ll new file mode 100644 index 000000000000..2e86a0f36077 --- /dev/null +++ b/llvm/test/MC/ARM/elf-eflags-eabi-cg.ll @@ -0,0 +1,13 @@ +; Codegen version to check for ELF header flags. +; +; RUN: llc %s -mtriple=thumbv7-linux-gnueabi -relocation-model=pic \ +; RUN: -filetype=obj -o - | elf-dump --dump-section-data | \ +; RUN: FileCheck %s + +define void @bar() nounwind { +entry: + ret void +} + +; For now the only e_flag set is EF_ARM_EABI_VER5 +;CHECK: 'e_flags', 0x05000000 diff --git a/llvm/test/MC/ARM/elf-eflags-eabi.s b/llvm/test/MC/ARM/elf-eflags-eabi.s index 6f70a5b9a79c..ea89eacf74fb 100644 --- a/llvm/test/MC/ARM/elf-eflags-eabi.s +++ b/llvm/test/MC/ARM/elf-eflags-eabi.s @@ -1,4 +1,3 @@ -@ XFAIL: @ RUN: llvm-mc %s -triple=armv7-linux-gnueabi -filetype=obj -o - | \ @ RUN: elf-dump --dump-section-data | FileCheck -check-prefix=OBJ %s .syntax unified