replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Reproducers] Force replay in synchronous mode. 

Replaying a reproducer in asynchronous mode never makes sense. This
patch disables asynchronous mode during replay.

Differential revision: https://reviews.llvm.org/D65547

llvm-svn: 367494
This commit is contained in:
Jonas Devlieghere 2019-07-31 23:34:45 +00:00
parent 45ff4868c4
commit 70df51b8a9
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lldb/lit/Reproducer/TestSynchronous.test Normal file
View File

@ -0,0 +1,13 @@
# Ensure that replay happens in synchronous mode.
# RUN: rm -rf %t.repro
# RUN: %lldb -x -b --capture --capture-path %t.repro -o 'script lldb.debugger.SetAsync(True)' -o 'script lldb.debugger.GetAsync()' -o 'reproducer generate' | FileCheck %s --check-prefix CAPTURE
# RUN: %lldb --replay %t.repro | FileCheck %s --check-prefix REPLAY
# CAPTURE: script lldb.debugger.SetAsync(True)
# CAPTURE-NEXT: script lldb.debugger.GetAsync()
# CAPTURE-NEXT: True
# REPLAY: script lldb.debugger.SetAsync(True)
# REPLAY-NEXT: script lldb.debugger.GetAsync()
# REPLAY-NEXT: False

6
lldb/source/Interpreter/CommandInterpreter.cpp
View File

@ -109,7 +109,7 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger,
Properties(OptionValuePropertiesSP(
new OptionValueProperties(ConstString("interpreter")))),
IOHandlerDelegate(IOHandlerDelegate::Completion::LLDBCommand),
m_debugger(debugger), m_synchronous_execution(synchronous_execution),
m_debugger(debugger), m_synchronous_execution(true),
m_skip_lldbinit_files(false), m_skip_app_init_files(false),
m_command_io_handler_sp(), m_comment_char('#'),
m_batch_command_mode(false), m_truncation_warning(eNoTruncation),
@ -118,6 +118,7 @@ CommandInterpreter::CommandInterpreter(Debugger &debugger,
SetEventName(eBroadcastBitThreadShouldExit, "thread-should-exit");
SetEventName(eBroadcastBitResetPrompt, "reset-prompt");
SetEventName(eBroadcastBitQuitCommandReceived, "quit");
SetSynchronous(synchronous_execution);
CheckInWithManager();
m_collection_sp->Initialize(g_interpreter_properties);
}
@ -2504,6 +2505,9 @@ void CommandInterpreter::HandleCommandsFromFile(
bool CommandInterpreter::GetSynchronous() { return m_synchronous_execution; }
void CommandInterpreter::SetSynchronous(bool value) {
// Asynchronous mode is not supported during reproducer replay.
if (repro::Reproducer::Instance().GetLoader())
return;
m_synchronous_execution = value;
}