MC: fix text section characteristics for WoA
link.exe requires that the text section has the IMAGE_SCN_MEM_16BIT flag set. Otherwise, it will treat the function as ARM. If this occurs, then jumps to the function will fail, switching from thumb to ARM mode execution. With this change, it is possible to link using the MSVC linker as well. llvm-svn: 210415
This commit is contained in:
parent
491c33e955
commit
70a0206e4b
|
@ -569,6 +569,8 @@ void MCObjectFileInfo::InitELFMCObjectFileInfo(Triple T) {
|
|||
|
||||
|
||||
void MCObjectFileInfo::InitCOFFMCObjectFileInfo(Triple T) {
|
||||
bool IsWoA = T.getArch() == Triple::arm || T.getArch() == Triple::thumb;
|
||||
|
||||
// The object file format cannot represent common symbols with explicit
|
||||
// alignments.
|
||||
CommDirectiveSupportsAlignment = false;
|
||||
|
@ -582,6 +584,7 @@ void MCObjectFileInfo::InitCOFFMCObjectFileInfo(Triple T) {
|
|||
SectionKind::getBSS());
|
||||
TextSection =
|
||||
Ctx->getCOFFSection(".text",
|
||||
(IsWoA ? COFF::IMAGE_SCN_MEM_16BIT : 0) |
|
||||
COFF::IMAGE_SCN_CNT_CODE |
|
||||
COFF::IMAGE_SCN_MEM_EXECUTE |
|
||||
COFF::IMAGE_SCN_MEM_READ,
|
||||
|
|
|
@ -0,0 +1,30 @@
|
|||
@ RUN: llvm-mc -triple thumbv7-windows-itanium -filetype obj -o - %s \
|
||||
@ RUN: | llvm-readobj -s - | FileCheck %s
|
||||
|
||||
.syntax unified
|
||||
.thumb
|
||||
|
||||
.text
|
||||
|
||||
.def function
|
||||
.type 32
|
||||
.scl 2
|
||||
.endef
|
||||
.global function
|
||||
.thumb_func
|
||||
function:
|
||||
bx lr
|
||||
|
||||
@ CHECK: Sections [
|
||||
@ CHECK: Section {
|
||||
@ CHECK: Name: .text
|
||||
@ CHECK: Characteristics [
|
||||
@ CHECK: IMAGE_SCN_ALIGN_4BYTES
|
||||
@ CHECK: IMAGE_SCN_CNT_CODE
|
||||
@ CHECK: IMAGE_SCN_MEM_16BIT
|
||||
@ CHECK: IMAGE_SCN_MEM_EXECUTE
|
||||
@ CHECK: IMAGE_SCN_MEM_PURGEABLE
|
||||
@ CHECK: IMAGE_SCN_MEM_READ
|
||||
@ CHECK: ]
|
||||
@ CHECK: }
|
||||
@ CHECK: ]
|
Loading…
Reference in New Issue