replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

use DiagRuntimeBehavior to silence the div/rem by zero warning when 

not in an evaluated context.  This removes some bogus warnings.

llvm-svn: 93258
This commit is contained in:
Chris Lattner 2010-01-12 21:30:55 +00:00
parent 18473f329d
commit 7011795ee4
4 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/Sema/SemaExpr.cpp
View File

@ -4868,7 +4868,8 @@ QualType Sema::CheckMultiplyDivideOperands(
// Check for division by zero.
if (isDiv &&
rex->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
Diag(Loc, diag::warn_division_by_zero) << rex->getSourceRange();
DiagRuntimeBehavior(Loc, PDiag(diag::warn_division_by_zero)
<< rex->getSourceRange());
return compType;
}
@ -4888,7 +4889,8 @@ QualType Sema::CheckRemainderOperands(
// Check for remainder by zero.
if (rex->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
Diag(Loc, diag::warn_remainder_by_zero) << rex->getSourceRange();
DiagRuntimeBehavior(Loc, PDiag(diag::warn_remainder_by_zero)
<< rex->getSourceRange());
return compType;
}

2
clang/test/Sema/exprs.c
View File

@ -120,5 +120,7 @@ void test17(int x) {
x = x % 0; // expected-warning {{remainder by zero is undefined}}
x /= 0; // expected-warning {{division by zero is undefined}}
x %= 0; // expected-warning {{remainder by zero is undefined}}
x = sizeof(x/0); // no warning.
}

3
clang/test/SemaTemplate/instantiate-expr-1.cpp
View File

@ -35,8 +35,7 @@ void test_BitfieldMinus() {
template<int I, int J>
struct BitfieldDivide {
int bitfield : I / J; // expected-error{{expression is not an integer constant expression}} \
// expected-note{{division by zero}} \
// expected-warning {{division by zero is undefined}}
// expected-note{{division by zero}}
};
void test_BitfieldDivide() {

2
clang/test/SemaTemplate/instantiate-static-var.cpp
View File

@ -2,7 +2,7 @@
template<typename T, T Divisor>
class X {
public:
static const T value = 10 / Divisor; // expected-error{{in-class initializer is not an integral constant expression}} expected-warning {{division by zero is undefined}}
static const T value = 10 / Divisor; // expected-error{{in-class initializer is not an integral constant expression}}
};
int array1[X<int, 2>::value == 5? 1 : -1];