diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td index cf1e6dc3ac80..49e37faae779 100644 --- a/clang/include/clang/Basic/DiagnosticSemaKinds.td +++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -1826,6 +1826,8 @@ def err_format_attribute_result_not : Error<"function does not return %0">; def err_format_attribute_implicit_this_format_string : Error< "format attribute cannot specify the implicit this argument as the format " "string">; +def err_common_not_supported_cplusplus : Error< + "common attribute is not supported in C++">; def warn_unknown_method_family : Warning<"unrecognized method family">; def err_init_method_bad_return_type : Error< "init methods must return an object pointer type, not %0">; diff --git a/clang/lib/Sema/SemaDeclAttr.cpp b/clang/lib/Sema/SemaDeclAttr.cpp index 9a68ca5a752c..a254caeff751 100644 --- a/clang/lib/Sema/SemaDeclAttr.cpp +++ b/clang/lib/Sema/SemaDeclAttr.cpp @@ -1746,6 +1746,12 @@ static void handleNoCommonAttr(Sema &S, Decl *D, const AttributeList &Attr) { static void handleCommonAttr(Sema &S, Decl *D, const AttributeList &Attr) { assert(!Attr.isInvalid()); + + if (S.LangOpts.CPlusPlus) { + S.Diag(Attr.getLoc(), diag::err_common_not_supported_cplusplus); + return; + } + if (isa(D)) D->addAttr(::new (S.Context) CommonAttr(Attr.getRange(), S.Context, diff --git a/clang/test/SemaCXX/attr-common.cpp b/clang/test/SemaCXX/attr-common.cpp new file mode 100644 index 000000000000..58b30133f52f --- /dev/null +++ b/clang/test/SemaCXX/attr-common.cpp @@ -0,0 +1,3 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +__attribute__((common)) int x; // expected-error {{common attribute is not supported in C++}}