replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

coff: fix the value of weak definitions. 

It looks like this doesn't get a lot of use.

llvm-svn: 270883
This commit is contained in:
Rafael Espindola 2016-05-26 18:04:53 +00:00
parent ec172c6da0
commit 6ddf5f4437
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/MC/WinCOFFObjectWriter.cpp
View File

@ -377,7 +377,7 @@ void WinCOFFObjectWriter::DefineSymbol(const MCSymbol &Symbol,
WeakDefault->Data.SectionNumber = COFF::IMAGE_SYM_ABSOLUTE;
WeakDefault->Data.StorageClass = COFF::IMAGE_SYM_CLASS_EXTERNAL;
WeakDefault->Data.Type = 0;
WeakDefault->Data.Value = 0;
WeakDefault->Data.Value = getSymbolValue(Symbol, Layout);
coff_symbol->Other = WeakDefault;
}

33
llvm/test/MC/COFF/weak-val.s Normal file
View File

@ -0,0 +1,33 @@
// RUN: llvm-mc -filetype=obj -triple x86_64-pc-win32 %s -o %t.o
// RUN: llvm-readobj -t %t.o | FileCheck %s
// test that b and .weak.b have the correct values.
.data
.long 42
.weak b
b:
.long 42
// CHECK: Symbol {
// CHECK: Name: b
// CHECK-NEXT: Value: 0
// CHECK-NEXT: Section: IMAGE_SYM_UNDEFINED (0)
// CHECK-NEXT: BaseType: Null (0x0)
// CHECK-NEXT: ComplexType: Null (0x0)
// CHECK-NEXT: StorageClass: WeakExternal (0x69)
// CHECK-NEXT: AuxSymbolCount: 1
// CHECK-NEXT: AuxWeakExternal {
// CHECK-NEXT: Linked: .weak.b.default (8)
// CHECK-NEXT: Search: Library (0x2)
// CHECK-NEXT: }
// CHECK-NEXT: }
// CHECK-NEXT: Symbol {
// CHECK-NEXT: Name: .weak.b.default
// CHECK-NEXT: Value: 4
// CHECK-NEXT: Section: IMAGE_SYM_ABSOLUTE (-1)
// CHECK-NEXT: BaseType: Null (0x0)
// CHECK-NEXT: ComplexType: Null (0x0)
// CHECK-NEXT: StorageClass: External (0x2)
// CHECK-NEXT: AuxSymbolCount: 0
// CHECK-NEXT: }