From 6babf2ae169c87b3e7f8c25582b98927c0c07336 Mon Sep 17 00:00:00 2001 From: George Karpenkov Date: Fri, 21 Sep 2018 20:36:21 +0000 Subject: [PATCH] [analyzer] [NFC] Prefer make_unique over "new" Differential Revision: https://reviews.llvm.org/D52336 llvm-svn: 342767 --- .../RetainCountChecker/RetainCountChecker.cpp | 25 ++++++++----------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp index 351816ae2085..de113bbd057e 100644 --- a/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp +++ b/clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp @@ -750,9 +750,8 @@ void RetainCountChecker::processNonLeakError(ProgramStateRef St, } assert(BT); - auto report = std::unique_ptr( - new CFRefReport(*BT, C.getASTContext().getLangOpts(), - SummaryLog, N, Sym)); + auto report = llvm::make_unique( + *BT, C.getASTContext().getLangOpts(), SummaryLog, N, Sym); report->addRange(ErrorRange); C.emitReport(std::move(report)); } @@ -951,9 +950,9 @@ void RetainCountChecker::checkReturnWithRetEffect(const ReturnStmt *S, ExplodedNode *N = C.addTransition(state, Pred, &ReturnOwnLeakTag); if (N) { const LangOptions &LOpts = C.getASTContext().getLangOpts(); - C.emitReport(std::unique_ptr(new CFRefLeakReport( - *getLeakAtReturnBug(LOpts), LOpts, - SummaryLog, N, Sym, C, IncludeAllocationLine))); + C.emitReport(llvm::make_unique( + *getLeakAtReturnBug(LOpts), LOpts, SummaryLog, N, Sym, C, + IncludeAllocationLine)); } } } @@ -978,9 +977,9 @@ void RetainCountChecker::checkReturnWithRetEffect(const ReturnStmt *S, if (!returnNotOwnedForOwned) returnNotOwnedForOwned.reset(new ReturnedNotOwnedForOwned(this)); - C.emitReport(std::unique_ptr(new CFRefReport( + C.emitReport(llvm::make_unique( *returnNotOwnedForOwned, C.getASTContext().getLangOpts(), - SummaryLog, N, Sym))); + SummaryLog, N, Sym)); } } } @@ -1182,9 +1181,8 @@ RetainCountChecker::handleAutoreleaseCounts(ProgramStateRef state, overAutorelease.reset(new OverAutorelease(this)); const LangOptions &LOpts = Ctx.getASTContext().getLangOpts(); - Ctx.emitReport(std::unique_ptr( - new CFRefReport(*overAutorelease, LOpts, - SummaryLog, N, Sym, os.str()))); + Ctx.emitReport(llvm::make_unique( + *overAutorelease, LOpts, SummaryLog, N, Sym, os.str())); } return nullptr; @@ -1235,9 +1233,8 @@ RetainCountChecker::processLeaks(ProgramStateRef state, : getLeakAtReturnBug(LOpts); assert(BT && "BugType not initialized."); - Ctx.emitReport(std::unique_ptr( - new CFRefLeakReport(*BT, LOpts, SummaryLog, N, *I, Ctx, - IncludeAllocationLine))); + Ctx.emitReport(llvm::make_unique( + *BT, LOpts, SummaryLog, N, *I, Ctx, IncludeAllocationLine)); } }