replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

add 'a' to chmod in llvm-lipo executability tests 

Summary:
When specifying symbolic permissions with + or -, if none of
a/u/g/o are specified, bits set in the umask are not affected.
This caused the llvm-lipo executability tests to fail on some
systems, e.g. having an umask of 027 would cause chmod -x to not
clear the executable bit for others. This change instead
uses chmod a-x, which clears all the executable bits regardless
of umask.

Reviewers: smeenai, hans, anushabasana

Reviewed By: smeenai

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65342

llvm-svn: 367142
This commit is contained in:
Bob Haarman 2019-07-26 18:44:06 +00:00
parent 485b8789de
commit 6baac18a76
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/test/tools/llvm-lipo/create-executable.test
View File

@ -3,11 +3,11 @@
# RUN: yaml2obj %p/Inputs/i386-slice.yaml > %t-i386.o
# RUN: yaml2obj %p/Inputs/x86_64-slice.yaml > %t-x86_64.o
# RUN: chmod -x %t-i386.o
# RUN: chmod -x %t-x86_64.o
# RUN: chmod a-x %t-i386.o
# RUN: chmod a-x %t-x86_64.o
# RUN: llvm-lipo %t-i386.o %t-x86_64.o -create -output %t-universal.o
# RUN: test ! -x %t-universal.o
# RUN: chmod +x %t-i386.o
# RUN: chmod a+x %t-i386.o
# RUN: llvm-lipo %t-i386.o %t-x86_64.o -create -output %t-universal.o
# RUN: test -x %t-universal.o

4
llvm/test/tools/llvm-lipo/thin-executable-universal-binary.test
View File

@ -2,11 +2,11 @@
# UNSUPPORTED: system-windows
# RUN: yaml2obj %s > %t-universal.o
# RUN: chmod -x %t-universal.o
# RUN: chmod a-x %t-universal.o
# RUN: llvm-lipo %t-universal.o -thin i386 -output %t32.o
# RUN: test ! -x %t32.o
# RUN: chmod +x %t-universal.o
# RUN: chmod a+x %t-universal.o
# RUN: llvm-lipo %t-universal.o -thin i386 -output %t32-ex.o
# RUN: test -x %t32-ex.o