Delete mkpatch. Everything it does is already done by svn diff by default.

llvm-svn: 110203
This commit is contained in:
Dan Gohman 2010-08-04 16:07:22 +00:00
parent 852287332a
commit 67c0212353
2 changed files with 6 additions and 48 deletions

View File

@ -107,18 +107,13 @@
patches may not apply correctly if the underlying code changes between the patches may not apply correctly if the underlying code changes between the
time the patch was created and the time it is applied.</li> time the patch was created and the time it is applied.</li>
<li>Patches should be made with this command: <li>Patches should be made with <tt>svn diff</tt>, or similar. If you use
<div class="doc_code"> a different tool, make sure it uses the <tt>diff -u</tt> format and
<pre> that it doesn't contain clutter which makes it hard to read.</li>
svn diff
</pre>
</div>
or with the utility <tt>utils/mkpatch</tt>, which makes it easy to read
the diff.</li>
<li>Patches should not include differences in generated code such as the code <li>If you are modifying generated files, such as the top-level
generated by <tt>autoconf</tt> or <tt>tblgen</tt>. The <tt>configure</tt> script, please separate out those changes into
<tt>utils/mkpatch</tt> utility takes care of this for you.</li> a separate patch from the rest of your changes.</li>
</ol> </ol>
<p>When sending a patch to a mailing list, it is a good idea to send it as an <p>When sending a patch to a mailing list, it is a good idea to send it as an

View File

@ -1,37 +0,0 @@
#!/bin/bash
#
# This script makes a patch for LLVM ensuring the correct diff options and
# putting the files in a standard review order.
function error {
retcode="$?"
echo "mkpatch: error: $1 ($retcode)"
exit 1
}
if [ ! -e llvm.spec.in ] ; then
error "Please change directory to the LLVM top source directory"
fi
if [ "$#" -ne 1 ] ; then
error "usage: utils/mkpatch [PATCH_NAME]"
fi
NAME="$1"
echo "mkpatch: Generating differences on top level files"
svn diff -N -x -u > "$NAME".patch.raw 2>&1
echo "mkpatch: Generating differences on all directories"
svn diff -x -u >> "$NAME".patch.raw 2>&1 \
autoconf docs utils include lib/System lib/Support lib/VMCore lib/AsmParser \
lib/Bitcode lib/Analysis lib/Transforms lib/CodeGen lib/Target \
lib/ExecutionEngine lib/Linker lib/MC \
tools test unittests runtime projects examples Xcode
echo "mkpatch: Removing cruft from the patch file"
sed -e '/^[?] .*/d' -e '/^cvs diff: Diffing/d' "$NAME".patch.raw | awk '\
BEGIN { deleting = 0; } \
/^Index: .*[.]cvs$/ { deleting = 1; fname=substr($0,7); \
print "Skipping: ", fname > "/dev/stderr"; } \
/^Index:.*/ && !/^Index: .*[.]cvs$/ { deleting = 0; } \
{ if (! deleting) { print; } } ' > "$NAME".patch || \
error "sed/awk cleanup failed"