replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Change the name of the variable used to detect if we are loading kexts to "load-kexts" instead of "disable-kext-loading" since the value is a boolean. This was requested by the person who requested the feature. It now defaults to true: 

(lldb) settings show plugin.dynamic-loader.darwin-kernel.load-kexts
plugin.dynamic-loader.darwin-kernel.load-kexts (boolean) = true

llvm-svn: 166315
This commit is contained in:
Greg Clayton 2012-10-19 20:53:18 +00:00
parent 14c43496c4
commit 66763eed3c
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
View File

@ -42,12 +42,12 @@ using namespace lldb_private;
static PropertyDefinition static PropertyDefinition
g_properties[] = g_properties[] =
{ {
{ "disable-kext-loading" , OptionValue::eTypeBoolean, false, false, NULL, NULL, "Disable kext image loading in a Darwin kernel debug session." }, { "load-kexts" , OptionValue::eTypeBoolean, true, true, NULL, NULL, "Automatically loads kext images when attaching to a kernel." },
{ NULL , OptionValue::eTypeInvalid, false, 0 , NULL, NULL, NULL } { NULL , OptionValue::eTypeInvalid, false, 0 , NULL, NULL, NULL }
}; };
enum { enum {
ePropertyDisableKextLoading ePropertyLoadKexts
}; };
class DynamicLoaderDarwinKernelProperties : public Properties class DynamicLoaderDarwinKernelProperties : public Properties
@ -74,9 +74,9 @@ public:
} }
bool bool
GetDisableKextLoading() const GetLoadKexts() const
{ {
const uint32_t idx = ePropertyDisableKextLoading; const uint32_t idx = ePropertyLoadKexts;
return m_collection_sp->GetPropertyAtIndexAsBoolean (NULL, idx, g_properties[idx].default_uint_value != 0); return m_collection_sp->GetPropertyAtIndexAsBoolean (NULL, idx, g_properties[idx].default_uint_value != 0);
} }
@ -244,7 +244,7 @@ DynamicLoaderDarwinKernel::OSKextLoadedKextSummary::LoadImageUsingMemoryModule (
ModuleSP memory_module_sp; ModuleSP memory_module_sp;
// If this is a kext and the user asked us to ignore kexts, don't try to load it. // If this is a kext and the user asked us to ignore kexts, don't try to load it.
if (kernel_image == false && GetGlobalProperties()->GetDisableKextLoading() == true) if (kernel_image == false && GetGlobalProperties()->GetLoadKexts() == false)
{ {
return false; return false;
} }