replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed incorrect StringRef::find usage. 

llvm-svn: 208898
This commit is contained in:
Alexander Kornienko 2014-05-15 15:56:58 +00:00
parent 2d35a06080
commit 6262d2349c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp
View File

@ -130,7 +130,7 @@ static llvm::Regex ConsumeGlob(StringRef &GlobList) {
for (char C : Glob) { for (char C : Glob) {
if (C == '*') if (C == '*')
RegexText.push_back('.'); RegexText.push_back('.');
else if (MetaChars.find(C)) else if (MetaChars.find(C) != StringRef::npos)
RegexText.push_back('\\'); RegexText.push_back('\\');
RegexText.push_back(C); RegexText.push_back(C);
} }

6
clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp
View File

@ -66,7 +66,7 @@ TEST(ChecksFilter, Simple) {
} }
TEST(ChecksFilter, Complex) { TEST(ChecksFilter, Complex) {
ChecksFilter Filter("*,-a.*,-b.*,a.a.*,-a.a.a.*,-..,-...,-..+,-*$,-*qwe*"); ChecksFilter Filter("*,-a.*,-b.*,a.1.*,-a.1.A.*,-..,-...,-..+,-*$,-*qwe*");
EXPECT_TRUE(Filter.isCheckEnabled("aaa")); EXPECT_TRUE(Filter.isCheckEnabled("aaa"));
EXPECT_TRUE(Filter.isCheckEnabled("qqq")); EXPECT_TRUE(Filter.isCheckEnabled("qqq"));
@ -74,8 +74,8 @@ TEST(ChecksFilter, Complex) {
EXPECT_FALSE(Filter.isCheckEnabled("a.b")); EXPECT_FALSE(Filter.isCheckEnabled("a.b"));
EXPECT_FALSE(Filter.isCheckEnabled("b.")); EXPECT_FALSE(Filter.isCheckEnabled("b."));
EXPECT_FALSE(Filter.isCheckEnabled("b.b")); EXPECT_FALSE(Filter.isCheckEnabled("b.b"));
EXPECT_TRUE(Filter.isCheckEnabled("a.a.b")); EXPECT_TRUE(Filter.isCheckEnabled("a.1.b"));
EXPECT_FALSE(Filter.isCheckEnabled("a.a.a.a")); EXPECT_FALSE(Filter.isCheckEnabled("a.1.A.a"));
EXPECT_FALSE(Filter.isCheckEnabled("qwe")); EXPECT_FALSE(Filter.isCheckEnabled("qwe"));
EXPECT_FALSE(Filter.isCheckEnabled("asdfqweasdf")); EXPECT_FALSE(Filter.isCheckEnabled("asdfqweasdf"));
EXPECT_TRUE(Filter.isCheckEnabled("asdfqwEasdf")); EXPECT_TRUE(Filter.isCheckEnabled("asdfqwEasdf"));