replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PDB/BinaryStreamTest.cpp: Appease mingw to avoid std::errc::no_buffer_space. 

Unfortunately, mingw's libstdc++ doesn't provide winsock2 errors.
That said, we should avoid raising OS-oriented error code in our code.

For now, I suggest to define custom error from std::error_category.
See also; https://reviews.llvm.org/D20592

llvm-svn: 296581
This commit is contained in:
NAKAMURA Takumi 2017-03-01 05:06:31 +00:00
parent d4e606273b
commit 623ab91b53
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/unittests/DebugInfo/PDB/BinaryStreamTest.cpp
View File

@ -56,7 +56,7 @@ public:
Error readBytes(uint32_t Offset, uint32_t Size,
ArrayRef<uint8_t> &Buffer) override {
if (Offset + Size > Data.size())
return errorCodeToError(make_error_code(std::errc::no_buffer_space));
return errorCodeToError(make_error_code(std::errc::function_not_supported));
uint32_t S = startIndex(Offset);
auto Ref = Data.drop_front(S);
if (Ref.size() >= Size) {
@ -75,7 +75,7 @@ public:
Error readLongestContiguousChunk(uint32_t Offset,
ArrayRef<uint8_t> &Buffer) override {
if (Offset >= Data.size())
return errorCodeToError(make_error_code(std::errc::no_buffer_space));
return errorCodeToError(make_error_code(std::errc::function_not_supported));
uint32_t S = startIndex(Offset);
Buffer = Data.drop_front(S);
return Error::success();
@ -85,7 +85,7 @@ public:
Error writeBytes(uint32_t Offset, ArrayRef<uint8_t> SrcData) override {
if (Offset + SrcData.size() > Data.size())
return errorCodeToError(make_error_code(std::errc::no_buffer_space));
return errorCodeToError(make_error_code(std::errc::function_not_supported));
if (SrcData.empty())
return Error::success();