replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[sancov] do not instrument nodes that are full pre-dominators 

Summary:
Without tree pruning clang has 2,667,552 points.
Wiht only dominators pruning: 1,515,586.
With both dominators & predominators pruning: 1,340,534.

Resubmit of r262103.

Differential Revision: http://reviews.llvm.org/D18341

llvm-svn: 264003
This commit is contained in:
Mike Aizatsky 2016-03-21 23:08:16 +00:00
parent 32835c82d5
commit 602f79275d
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
View File

@ -315,20 +315,24 @@ bool SanitizerCoverageModule::runOnModule(Module &M) {
return true;
}
static bool shouldInstrumentBlock(const BasicBlock *BB,
const DominatorTree *DT) {
static bool shouldInstrumentBlock(const BasicBlock *BB, const DominatorTree *DT,
const PostDominatorTree *PDT) {
if (!ClPruneBlocks)
return true;
if (succ_begin(BB) == succ_end(BB))
return true;
// Check if BB dominates all its successors.
bool DominatesAll = succ_begin(BB) != succ_end(BB);
for (const BasicBlock *SUCC : make_range(succ_begin(BB), succ_end(BB))) {
if (!DT->dominates(BB, SUCC))
return true;
DominatesAll &= DT->dominates(BB, SUCC);
}
return false;
// Check if BB pre-dominates all predecessors.
bool PreDominatesAll = pred_begin(BB) != pred_end(BB);
for (const BasicBlock *PRED : make_range(pred_begin(BB), pred_end(BB))) {
PreDominatesAll &= PDT->dominates(BB, PRED);
}
return !(DominatesAll || PreDominatesAll);
}
bool SanitizerCoverageModule::runOnFunction(Function &F) {
@ -349,10 +353,13 @@ bool SanitizerCoverageModule::runOnFunction(Function &F) {
SmallVector<Instruction *, 8> CmpTraceTargets;
SmallVector<Instruction *, 8> SwitchTraceTargets;
DominatorTree DT;
DT.recalculate(F);
const DominatorTree *DT =
&getAnalysis<DominatorTreeWrapperPass>(F).getDomTree();
const PostDominatorTree *PDT =
&getAnalysis<PostDominatorTreeWrapperPass>(F).getPostDomTree();
for (auto &BB : F) {
if (shouldInstrumentBlock(&BB, &DT))
if (shouldInstrumentBlock(&BB, DT, PDT))
BlocksToInstrument.push_back(&BB);
for (auto &Inst : BB) {
if (Options.IndirectCalls) {