Remove skipUnlessListedRemote test decorator
This decorator was used in only one test, and it's behaviour was quite complicated. It skipped if: - test was remote - platform was *not* android I am not aware of anyone running tests with this configuration (and even then, I am not aware of a reason why the test should not pass), but if TestLoadUnload starts breaking for you after this commit, please disable the test with @expectedFailureAll(remote=True, oslist=[YOUR_PLATFORM]) llvm-svn: 259642
This commit is contained in:
parent
e774126c96
commit
5f496fb941
|
@ -125,7 +125,6 @@ class LoadUnloadTestCase(TestBase):
|
|||
substrs = [new_dylib])
|
||||
|
||||
@skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase support
|
||||
@skipUnlessListedRemote(['android'])
|
||||
@expectedFailureAndroid # wrong source file shows up for hidden library
|
||||
@skipIfWindows # Windows doesn't have dlopen and friends, dynamic libraries work differently
|
||||
def test_dyld_library_path(self):
|
||||
|
@ -182,7 +181,6 @@ class LoadUnloadTestCase(TestBase):
|
|||
|
||||
@expectedFailureAll(bugnumber="llvm.org/pr25805", hostoslist=["windows"], compiler="gcc", archs=["i386"], triple='.*-android')
|
||||
@skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase support
|
||||
@skipUnlessListedRemote(['android'])
|
||||
@skipIfWindows # Windows doesn't have dlopen and friends, dynamic libraries work differently
|
||||
def test_lldb_process_load_and_unload_commands(self):
|
||||
"""Test that lldb process load/unload command work correctly."""
|
||||
|
@ -241,7 +239,6 @@ class LoadUnloadTestCase(TestBase):
|
|||
self.runCmd("process continue")
|
||||
|
||||
@skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase support
|
||||
@skipUnlessListedRemote(['android'])
|
||||
def test_load_unload(self):
|
||||
"""Test breakpoint by name works correctly with dlopen'ing."""
|
||||
|
||||
|
@ -283,7 +280,6 @@ class LoadUnloadTestCase(TestBase):
|
|||
substrs = [' resolved, hit count = 2'])
|
||||
|
||||
@skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase support
|
||||
@skipUnlessListedRemote(['android'])
|
||||
@skipIfWindows # Windows doesn't have dlopen and friends, dynamic libraries work differently
|
||||
def test_step_over_load (self):
|
||||
"""Test stepping over code that loads a shared library works correctly."""
|
||||
|
@ -313,7 +309,6 @@ class LoadUnloadTestCase(TestBase):
|
|||
'stop reason = step over'])
|
||||
|
||||
@skipIfFreeBSD # llvm.org/pr14424 - missing FreeBSD Makefiles/testcase support
|
||||
@skipUnlessListedRemote(['android'])
|
||||
@skipIfWindows # Windows doesn't have dlopen and friends, dynamic libraries work differently
|
||||
@unittest2.expectedFailure("llvm.org/pr25806")
|
||||
def test_static_init_during_load (self):
|
||||
|
|
|
@ -819,18 +819,6 @@ def skipIfRemote(func):
|
|||
return "skip on remote platform" if lldb.remote_platform else None
|
||||
return skipTestIfFn(is_remote)(func)
|
||||
|
||||
def skipUnlessListedRemote(remote_list=None):
|
||||
def is_remote_unlisted(self):
|
||||
if remote_list and lldb.remote_platform:
|
||||
triple = self.dbg.GetSelectedPlatform().GetTriple()
|
||||
for r in remote_list:
|
||||
if r in triple:
|
||||
return None
|
||||
return "skipping because remote is not listed"
|
||||
else:
|
||||
return None
|
||||
return skipTestIfFn(is_remote_unlisted)
|
||||
|
||||
def skipIfRemoteDueToDeadlock(func):
|
||||
"""Decorate the item to skip tests if testing remotely due to the test deadlocking."""
|
||||
def is_remote():
|
||||
|
|
Loading…
Reference in New Issue