Revert r375116: "[lit] Extend internal diff to support `-` argument"
This series of patches still breaks a Windows bot. llvm-svn: 375120
This commit is contained in:
parent
3e0f4f8e92
commit
5e684e8d88
|
@ -31,13 +31,8 @@ def getDirTree(path, basedir=""):
|
||||||
def compareTwoFiles(flags, filepaths):
|
def compareTwoFiles(flags, filepaths):
|
||||||
filelines = []
|
filelines = []
|
||||||
for file in filepaths:
|
for file in filepaths:
|
||||||
if file == "-":
|
with open(file, 'rb') as file_bin:
|
||||||
stdin_fileno = sys.stdin.fileno()
|
filelines.append(file_bin.readlines())
|
||||||
with os.fdopen(os.dup(stdin_fileno), 'rb') as stdin_bin:
|
|
||||||
filelines.append(stdin_bin.readlines())
|
|
||||||
else:
|
|
||||||
with open(file, 'rb') as file_bin:
|
|
||||||
filelines.append(file_bin.readlines())
|
|
||||||
|
|
||||||
try:
|
try:
|
||||||
return compareTwoTextFiles(flags, filepaths, filelines,
|
return compareTwoTextFiles(flags, filepaths, filelines,
|
||||||
|
@ -218,13 +213,10 @@ def main(argv):
|
||||||
exitCode = 0
|
exitCode = 0
|
||||||
try:
|
try:
|
||||||
for file in args:
|
for file in args:
|
||||||
if file != "-" and not os.path.isabs(file):
|
if not os.path.isabs(file):
|
||||||
file = os.path.realpath(os.path.join(os.getcwd(), file))
|
file = os.path.realpath(os.path.join(os.getcwd(), file))
|
||||||
|
|
||||||
if flags.recursive_diff:
|
if flags.recursive_diff:
|
||||||
if file == "-":
|
|
||||||
sys.stderr.write("Error: cannot recursively compare '-'\n")
|
|
||||||
sys.exit(1)
|
|
||||||
dir_trees.append(getDirTree(file))
|
dir_trees.append(getDirTree(file))
|
||||||
else:
|
else:
|
||||||
filepaths.append(file)
|
filepaths.append(file)
|
||||||
|
|
|
@ -5,11 +5,5 @@
|
||||||
# RUN: diff -u diff-in.utf8 diff-in.bin && false || true
|
# RUN: diff -u diff-in.utf8 diff-in.bin && false || true
|
||||||
# RUN: diff -u diff-in.bin diff-in.utf8 && false || true
|
# RUN: diff -u diff-in.bin diff-in.utf8 && false || true
|
||||||
|
|
||||||
# RUN: cat diff-in.bin | diff -u - diff-in.bin
|
|
||||||
# RUN: cat diff-in.bin | diff -u diff-in.bin -
|
|
||||||
# RUN: cat diff-in.bin | diff -u diff-in.utf16 - && false || true
|
|
||||||
# RUN: cat diff-in.bin | diff -u diff-in.utf8 - && false || true
|
|
||||||
# RUN: cat diff-in.bin | diff -u - diff-in.utf8 && false || true
|
|
||||||
|
|
||||||
# Fail so lit will print output.
|
# Fail so lit will print output.
|
||||||
# RUN: false
|
# RUN: false
|
||||||
|
|
|
@ -5,16 +5,6 @@
|
||||||
# RUN: diff %t.foo %t.foo | FileCheck -allow-empty -check-prefix=EMPTY %s
|
# RUN: diff %t.foo %t.foo | FileCheck -allow-empty -check-prefix=EMPTY %s
|
||||||
# RUN: diff -u %t.foo %t.bar | FileCheck %s && false || true
|
# RUN: diff -u %t.foo %t.bar | FileCheck %s && false || true
|
||||||
|
|
||||||
# Check input pipe.
|
|
||||||
# RUN: echo foo | diff -u - %t.foo
|
|
||||||
# RUN: echo foo | diff -u %t.foo -
|
|
||||||
# RUN: echo bar | diff -u %t.foo - && false || true
|
|
||||||
# RUN: echo bar | diff -u - %t.foo && false || true
|
|
||||||
|
|
||||||
# Check output and input pipes at the same time.
|
|
||||||
# RUN: echo foo | diff - %t.foo | FileCheck -allow-empty -check-prefix=EMPTY %s
|
|
||||||
# RUN: echo bar | diff -u %t.foo - | FileCheck %s && false || true
|
|
||||||
|
|
||||||
# Fail so lit will print output.
|
# Fail so lit will print output.
|
||||||
# RUN: false
|
# RUN: false
|
||||||
|
|
||||||
|
|
|
@ -1,2 +0,0 @@
|
||||||
# diff -r currently cannot handle stdin.
|
|
||||||
# RUN: diff -r - %t
|
|
|
@ -1,2 +0,0 @@
|
||||||
# diff -r currently cannot handle stdin.
|
|
||||||
# RUN: diff -r %t -
|
|
|
@ -8,7 +8,7 @@
|
||||||
#
|
#
|
||||||
# END.
|
# END.
|
||||||
|
|
||||||
# CHECK: Failing Tests (32)
|
# CHECK: Failing Tests (30)
|
||||||
# CHECK: Failing Tests (1)
|
# CHECK: Failing Tests (1)
|
||||||
# CHECK: Failing Tests (2)
|
# CHECK: Failing Tests (2)
|
||||||
# CHECK: error: argument --max-failures: requires positive integer, but found '0'
|
# CHECK: error: argument --max-failures: requires positive integer, but found '0'
|
||||||
|
|
|
@ -81,60 +81,6 @@
|
||||||
# CHECK: error: command failed with exit status: 1
|
# CHECK: error: command failed with exit status: 1
|
||||||
# CHECK: $ "true"
|
# CHECK: $ "true"
|
||||||
|
|
||||||
# CHECK: $ "cat" "diff-in.bin"
|
|
||||||
# CHECK-NOT: error
|
|
||||||
# CHECK: $ "diff" "-u" "-" "diff-in.bin"
|
|
||||||
# CHECK-NOT: error
|
|
||||||
|
|
||||||
# CHECK: $ "cat" "diff-in.bin"
|
|
||||||
# CHECK-NOT: error
|
|
||||||
# CHECK: $ "diff" "-u" "diff-in.bin" "-"
|
|
||||||
# CHECK-NOT: error
|
|
||||||
|
|
||||||
# CHECK: $ "cat" "diff-in.bin"
|
|
||||||
# CHECK-NOT: error
|
|
||||||
# CHECK: $ "diff" "-u" "diff-in.utf16" "-"
|
|
||||||
# CHECK: # command output:
|
|
||||||
# CHECK-NEXT: ---
|
|
||||||
# CHECK-NEXT: +++
|
|
||||||
# CHECK-NEXT: @@
|
|
||||||
# CHECK-NEXT: {{^ .f.o.o.$}}
|
|
||||||
# CHECK-NEXT: {{^-.b.a.r.$}}
|
|
||||||
# CHECK-NEXT: {{^\+.b.a.r..}}
|
|
||||||
# CHECK-NEXT: {{^ .b.a.z.$}}
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
# CHECK: $ "true"
|
|
||||||
|
|
||||||
# CHECK: $ "cat" "diff-in.bin"
|
|
||||||
# CHECK-NOT: error
|
|
||||||
# CHECK: $ "diff" "-u" "diff-in.utf8" "-"
|
|
||||||
# CHECK: # command output:
|
|
||||||
# CHECK-NEXT: ---
|
|
||||||
# CHECK-NEXT: +++
|
|
||||||
# CHECK-NEXT: @@
|
|
||||||
# CHECK-NEXT: -foo
|
|
||||||
# CHECK-NEXT: -bar
|
|
||||||
# CHECK-NEXT: -baz
|
|
||||||
# CHECK-NEXT: {{^\+.f.o.o.$}}
|
|
||||||
# CHECK-NEXT: {{^\+.b.a.r..}}
|
|
||||||
# CHECK-NEXT: {{^\+.b.a.z.$}}
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
# CHECK: $ "true"
|
|
||||||
|
|
||||||
# CHECK: $ "diff" "-u" "-" "diff-in.utf8"
|
|
||||||
# CHECK: # command output:
|
|
||||||
# CHECK-NEXT: ---
|
|
||||||
# CHECK-NEXT: +++
|
|
||||||
# CHECK-NEXT: @@
|
|
||||||
# CHECK-NEXT: {{^\-.f.o.o.$}}
|
|
||||||
# CHECK-NEXT: {{^\-.b.a.r..}}
|
|
||||||
# CHECK-NEXT: {{^\-.b.a.z.$}}
|
|
||||||
# CHECK-NEXT: +foo
|
|
||||||
# CHECK-NEXT: +bar
|
|
||||||
# CHECK-NEXT: +baz
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
# CHECK: $ "true"
|
|
||||||
|
|
||||||
# CHECK: $ "false"
|
# CHECK: $ "false"
|
||||||
|
|
||||||
# CHECK: ***
|
# CHECK: ***
|
||||||
|
@ -212,51 +158,6 @@
|
||||||
# CHECK-NOT: error
|
# CHECK-NOT: error
|
||||||
# CHECK: $ "true"
|
# CHECK: $ "true"
|
||||||
|
|
||||||
# CHECK: $ "echo" "foo"
|
|
||||||
# CHECK: $ "diff" "-u" "-" "{{[^"]*}}.foo"
|
|
||||||
# CHECK-NOT: note
|
|
||||||
# CHECK-NOT: error
|
|
||||||
|
|
||||||
# CHECK: $ "echo" "foo"
|
|
||||||
# CHECK: $ "diff" "-u" "{{[^"]*}}.foo" "-"
|
|
||||||
# CHECK-NOT: note
|
|
||||||
# CHECK-NOT: error
|
|
||||||
|
|
||||||
# CHECK: $ "echo" "bar"
|
|
||||||
# CHECK: $ "diff" "-u" "{{[^"]*}}.foo" "-"
|
|
||||||
# CHECK: # command output:
|
|
||||||
# CHECK: @@
|
|
||||||
# CHECK-NEXT: -foo
|
|
||||||
# CHECK-NEXT: +bar
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
# CHECK: $ "true"
|
|
||||||
|
|
||||||
# CHECK: $ "echo" "bar"
|
|
||||||
# CHECK: $ "diff" "-u" "-" "{{[^"]*}}.foo"
|
|
||||||
# CHECK: # command output:
|
|
||||||
# CHECK: @@
|
|
||||||
# CHECK-NEXT: -bar
|
|
||||||
# CHECK-NEXT: +foo
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
# CHECK: $ "true"
|
|
||||||
|
|
||||||
# CHECK: $ "echo" "foo"
|
|
||||||
# CHECK: $ "diff" "-" "{{[^"]*}}.foo"
|
|
||||||
# CHECK-NOT: note
|
|
||||||
# CHECK-NOT: error
|
|
||||||
# CHECK: $ "FileCheck"
|
|
||||||
# CHECK-NOT: note
|
|
||||||
# CHECK-NOT: error
|
|
||||||
|
|
||||||
# CHECK: $ "echo" "bar"
|
|
||||||
# CHECK: $ "diff" "-u" "{{[^"]*}}.foo" "-"
|
|
||||||
# CHECK: note: command had no output on stdout or stderr
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
# CHECK: $ "FileCheck"
|
|
||||||
# CHECK-NOT: note
|
|
||||||
# CHECK-NOT: error
|
|
||||||
# CHECK: $ "true"
|
|
||||||
|
|
||||||
# CHECK: $ "false"
|
# CHECK: $ "false"
|
||||||
|
|
||||||
# CHECK: ***
|
# CHECK: ***
|
||||||
|
@ -315,20 +216,6 @@
|
||||||
# CHECK: File {{.*}}dir1{{.*}}extra_file is a regular empty file while file {{.*}}dir2{{.*}}extra_file is a directory
|
# CHECK: File {{.*}}dir1{{.*}}extra_file is a regular empty file while file {{.*}}dir2{{.*}}extra_file is a directory
|
||||||
# CHECK: error: command failed with exit status: 1
|
# CHECK: error: command failed with exit status: 1
|
||||||
|
|
||||||
# CHECK: FAIL: shtest-shell :: diff-r-error-7.txt
|
|
||||||
# CHECK: *** TEST 'shtest-shell :: diff-r-error-7.txt' FAILED ***
|
|
||||||
# CHECK: $ "diff" "-r" "-" "{{[^"]*}}"
|
|
||||||
# CHECK: # command stderr:
|
|
||||||
# CHECK: Error: cannot recursively compare '-'
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
|
|
||||||
# CHECK: FAIL: shtest-shell :: diff-r-error-8.txt
|
|
||||||
# CHECK: *** TEST 'shtest-shell :: diff-r-error-8.txt' FAILED ***
|
|
||||||
# CHECK: $ "diff" "-r" "{{[^"]*}}" "-"
|
|
||||||
# CHECK: # command stderr:
|
|
||||||
# CHECK: Error: cannot recursively compare '-'
|
|
||||||
# CHECK: error: command failed with exit status: 1
|
|
||||||
|
|
||||||
# CHECK: PASS: shtest-shell :: diff-r.txt
|
# CHECK: PASS: shtest-shell :: diff-r.txt
|
||||||
|
|
||||||
|
|
||||||
|
@ -539,4 +426,4 @@
|
||||||
# CHECK: PASS: shtest-shell :: sequencing-0.txt
|
# CHECK: PASS: shtest-shell :: sequencing-0.txt
|
||||||
# CHECK: XFAIL: shtest-shell :: sequencing-1.txt
|
# CHECK: XFAIL: shtest-shell :: sequencing-1.txt
|
||||||
# CHECK: PASS: shtest-shell :: valid-shell.txt
|
# CHECK: PASS: shtest-shell :: valid-shell.txt
|
||||||
# CHECK: Failing Tests (32)
|
# CHECK: Failing Tests (30)
|
||||||
|
|
Loading…
Reference in New Issue